Fixed typo and increase clarity on non-dimension coordinate variable vs name #345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
anthropikos
commented
Oct 7, 2025
anthropikos
commented
- Typo: an "i" was missing in the quoted name.
- It was unclear which is the variable name and which is the dimension name, thus I made editorial changes to improve clarity.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
ianhi
requested changes
Oct 7, 2025
There was a problem hiding this comment.
Thanks very much for the find @anthropikos ! I left one request regarding the precise phrasing because I don''t think this new version is 100% right yet. But agree that this is a step in the right direction.
|
🎊 PR Preview f8cd417 has been successfully built and deployed to https://xarray-contrib-xarray-tutorial-preview-pr-345.surge.sh 🕐 Build time: 0.011s
🤖 By surge-preview |
ianhi
approved these changes
Oct 8, 2025
|
Thanks very much @anthropikos ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.