Introduce BaseActionViewController #1378
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wutschel
force-pushed
the
rework_baseactionvc
branch
4 times, most recently
from
1e693eb to
ae718ca
Compare
wutschel
force-pushed
the
rework_baseactionvc
branch
2 times, most recently
from
39df9c0 to
ee57baa
Compare
wutschel
force-pushed
the
rework_baseactionvc
branch
from
ee57baa to
29582b3
Compare
Variable action2 is obsolete. ActivityIndicator shall be only stopped after Playlist.Insert was executed.
Variable action2 is obsolete. ActivityIndicator shall be only stopped after Playlist.Insert was executed.
Adapt method playerOpen to reduce code duplication. Remove condition inside startPlayback.
Avoids button stays disabled after early return.
This base class implements actions shared by multiple UIViewControllers, e.g. play, queue, open URL, show remote, simple JSON commands and more.
Let iPhone's MasterVC only start instances of BaseActionController which simplifies their allocation.
The parameter httpAPIcallback (for backwards compatibility to Kodi "Eden") is mostly unused, so simply use the already existing simpleAction:params instead. Rename method to simpleAction:params:xbmcHttp: for alignment with other classes and to follow the fucntion of the xbmcHttp: parameter which is not a callback but a command.
The parameter httpAPIcallback (for backwards compatibility to Kodi "Eden" is always nil, so remove it. Rename method to simpleAction:params for alignment with other classes.
wutschel
force-pushed
the
rework_baseactionvc
branch
from
29582b3 to
15ef065
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #740.
This PR introduces new base class
BaseActionViewControllerwhich implements actions commonly used across severalUIViewControllerswithin the app. The most prominent examples are API actions around "Player", "Playlist", "PVR" as well as loading remote or NowPlaying views.The first commits are preparing the different implementations by unifying the logic, the next commits are moving the common implementation to the new base class.
Summary for release notes
Maintenance: Unify methods used across several ViewControllers