Maintenance: Remove property defaultThumb and review default thumbs #1426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wutschel
force-pushed
the
mainmenu_defaultthumb
branch
2 times, most recently
from
c444ff9 to
2dee2a8
Compare
This ensures it is contained in newParameters, if parameters["extra_info_parameters"] is empty, and by that ensures that defaultThumb does not fall back to default in this situation.
wutschel
force-pushed
the
mainmenu_defaultthumb
branch
from
2dee2a8 to
751545e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the property
defaultThumbfrommainMenuand explicitly sets the default thumbs for each menu. This way also few wrong default thumbs got corrected.Summary for release notes
Maintenance: Remove property defaultThumb and review default thumbs