Skip to content

Maintenance: Remove property defaultThumb and review default thumbs #1426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wutschel wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Maintenance: Remove property defaultThumb and review default thumbs #1426

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3835a2a
Do not create NSString from nil defaultThumb
wutschel Dec 29, 2025
d333167
Move up setting key "defaultThumb"
wutschel Dec 29, 2025
a71113e
Remove property defaultThumb and review default thumbs
wutschel Nov 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions XBMC Remote/DetailViewController.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1364,9 +1364,9 @@ - (void)viewChild:(NSIndexPath*)indexPath item:(NSDictionary*)item displayPoint:
@([parameters[@"collectionViewRecentlyAdded"] boolValue]), @"collectionViewRecentlyAdded",
pvrExtraInfo, @"pvrExtraInfo",
kodiExtrasPropertiesMinimumVersion, @"kodiExtrasPropertiesMinimumVersion",
parameters[@"defaultThumb"] ?: @"", @"defaultThumb",
parameters[@"extra_info_parameters"], @"extra_info_parameters",
newSectionParameters, @"extra_section_parameters",
[NSString stringWithFormat:@"%@", parameters[@"defaultThumb"]], @"defaultThumb",
parameters[@"watchedListenedStrings"], @"watchedListenedStrings",
nil];
if (parameters[@"available_sort_methods"] != nil) {
Expand Down Expand Up @@ -2049,11 +2049,11 @@ - (void)setWatchedOverlayPosition {
- (void)setCellLayoutParameters {
mainMenu *menuItem = self.detailItem;
NSDictionary *parameters = menuItem.mainParameters[chosenTab];
if ([parameters[@"defaultThumb"] length] != 0 && ![parameters[@"defaultThumb"] isEqualToString:@"(null)"]) {
if ([parameters[@"defaultThumb"] length] != 0) {
defaultThumb = parameters[@"defaultThumb"];
}
else {
defaultThumb = menuItem.defaultThumb;
defaultThumb = @"nocover_filemode";
}
if (parameters[@"rowHeight"]) {
cellHeight = [parameters[@"rowHeight"] intValue];
Expand Down
1 change: 0 additions & 1 deletion XBMC Remote/mainMenu.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,6 @@ typedef NS_ENUM(NSInteger, ViewModes) {
@property (nonatomic) BOOL enableSection;
@property (nonatomic, copy) NSString *icon;
@property (nonatomic, copy) NSArray *mainMethod;
@property (nonatomic, copy) NSString *defaultThumb;
@property (nonatomic, copy) NSArray *mainButtons;
@property (nonatomic, copy) NSArray *mainFields;
@property (nonatomic, strong) NSMutableArray *mainParameters;
Expand Down
Loading