Improvement: iOS style haptic feedback via UIImpactFeedbackGenerator #1427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wutschel
force-pushed
the
improve_hapticfeedback
branch
from
e71764e to
ac57295
Compare
Avoids code duplication by introducing a helper method, which is placed in Utilities for future purpose (providing haptic feedback from other controllers as well). The generator is made static and only created once to avoid feedback delays. The feedback is now a medium haptic one-time impact which comes right with touching the remote buttons.
wutschel
force-pushed
the
improve_hapticfeedback
branch
from
ac57295 to
2064c03
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Avoids code duplication by introducing a helper method
giveHapticFeedback, which is placed inUtilitiesfor future purpose (providing haptic feedback from other controllers as well). The instance ofUIImpactFeedbackGeneratoris made static and only created once to avoid feedback delays. The feedback is now a medium haptic one-time impact (UIImpactFeedbackStyleMedium) which comes right with touching the remote buttons. This is more in line with how other iOS functions give haptic feedback.Important: This requires to have system level haptic feedback enabled in the setting of your iOS device.
Summary for release notes
Improvement: iOS style haptic feedback via UIImpactFeedbackGenerator