Add non-"ignore"-able assert macros, user-friendly VK_CHECK, and durable fatal error logging #2535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A number of bug reports have been muddied due to the ability to "Ignore" assertion failures on Windows. This change adds a fatal error log to capture details needed for bug reports and puts an explicit exit after nv2a assertion failures to prevent continuation leading to undefined states.
This extends the VK_CHECK macro to print additional information intended to allow users to self-diagnose very common problems (like lack of VRAM, the usecase included here).
abaire
force-pushed
the
add_friendly_fatal_error_messages
branch
from
159a030 to
1508b35
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to address a few problems:
exitcall after the asserts so that ignoring the assert will not allow continued operation in an undefined statexemu-fatal-error.logfile in the user's home directory and mentions the existence of that file in the assertion message. It also logs actual error values to that log, so there's more data than "glGetError returned some error".This extends PR #2453, since there is some overlap in intent, and could replace it or be rebased after that PR is merged.