style(clang-format): Re-order header include priorities so external headers appear before the project's headers; Update to clang-format v21.1 and apply the corresponding format changes.

.gitignore

@@ -1,2 +1,7 @@
+# Linting config files symlinked from dev-utils
+/.clang-format
+/.clang-tidy
+
+# Build related directories
 .task/
 build/

lint-requirements.txt

@@ -1,4 +1,4 @@
 clang-format>=20.1
-clang-tidy>=20.1
+clang-tidy>=21.1
 gersemi>=0.16.2
 yamllint>=1.35.1

src/.clang-format

@@ -6,11 +6,11 @@ IncludeCategories:
 
   # Project library headers
   - Regex: "^<log_surgeon"
-    Priority: 3
+    Priority: 4
 
   # External library headers. Update when adding new libraries.
   - Regex: "^<(fmt|gsl)"
-    Priority: 4
+    Priority: 3
 
   # C system headers
   - Regex: "^<.+\\.h>"
@@ -19,7 +19,3 @@ IncludeCategories:
   # C++ standard libraries
   - Regex: "^<.+>"
     Priority: 2
-
-  # Project relative headers
-  - Regex: "^\".+\""
-    Priority: 5

src/log_surgeon/SchemaParser.cpp

@@ -23,7 +23,8 @@
 #include <log_surgeon/utils.hpp>
 
 using ParserValueRegex = log_surgeon::ParserValue<std::unique_ptr<
-        log_surgeon::finite_automata::RegexAST<log_surgeon::finite_automata::ByteNfaState>>>;
+        log_surgeon::finite_automata::RegexAST<log_surgeon::finite_automata::ByteNfaState>
+>>;
 using RegexASTByte
         = log_surgeon::finite_automata::RegexAST<log_surgeon::finite_automata::ByteNfaState>;
 using RegexASTGroupByte
@@ -32,8 +33,8 @@ using RegexASTIntegerByte
         = log_surgeon::finite_automata::RegexASTInteger<log_surgeon::finite_automata::ByteNfaState>;
 using RegexASTLiteralByte
         = log_surgeon::finite_automata::RegexASTLiteral<log_surgeon::finite_automata::ByteNfaState>;
-using RegexASTMultiplicationByte = log_surgeon::finite_automata::RegexASTMultiplication<
-        log_surgeon::finite_automata::ByteNfaState>;
+using RegexASTMultiplicationByte = log_surgeon::finite_automata::
+        RegexASTMultiplication<log_surgeon::finite_automata::ByteNfaState>;
 using RegexASTOrByte
         = log_surgeon::finite_automata::RegexASTOr<log_surgeon::finite_automata::ByteNfaState>;
 using RegexASTCatByte

src/log_surgeon/finite_automata/Dfa.hpp

@@ -16,6 +16,9 @@
 #include <utility>
 #include <vector>
 
+#include <fmt/format.h>
+#include <fmt/ranges.h>
+
 #include <log_surgeon/Constants.hpp>
 #include <log_surgeon/finite_automata/DeterminizationConfiguration.hpp>
 #include <log_surgeon/finite_automata/DfaStatePair.hpp>
@@ -25,9 +28,6 @@
 #include <log_surgeon/finite_automata/TagOperation.hpp>
 #include <log_surgeon/Token.hpp>
 
-#include <fmt/format.h>
-#include <fmt/ranges.h>
-
 namespace log_surgeon::finite_automata {
 /**
  * Represents a Deterministic Finite Automaton (DFA).

src/log_surgeon/finite_automata/DfaState.hpp

@@ -12,15 +12,15 @@
 #include <unordered_map>
 #include <vector>
 
+#include <fmt/format.h>
+#include <fmt/ranges.h>
+
 #include <log_surgeon/Constants.hpp>
 #include <log_surgeon/finite_automata/DfaTransition.hpp>
 #include <log_surgeon/finite_automata/RegisterOperation.hpp>
 #include <log_surgeon/finite_automata/StateType.hpp>
 #include <log_surgeon/finite_automata/UnicodeIntervalTree.hpp>
 
-#include <fmt/format.h>
-#include <fmt/ranges.h>
-
 namespace log_surgeon::finite_automata {
 template <StateType state_type>
 class DfaState;

src/log_surgeon/finite_automata/DfaTransition.hpp

@@ -8,12 +8,12 @@
 #include <utility>
 #include <vector>
 
-#include <log_surgeon/finite_automata/RegisterOperation.hpp>
-#include <log_surgeon/finite_automata/StateType.hpp>
-
 #include <fmt/format.h>
 #include <fmt/ranges.h>
 
+#include <log_surgeon/finite_automata/RegisterOperation.hpp>
+#include <log_surgeon/finite_automata/StateType.hpp>
+
 namespace log_surgeon::finite_automata {
 template <StateType state_type>
 class DfaState;

src/log_surgeon/finite_automata/Nfa.hpp

@@ -12,6 +12,9 @@
 #include <utility>
 #include <vector>
 
+#include <fmt/format.h>
+#include <fmt/ranges.h>
+
 #include <log_surgeon/Constants.hpp>
 #include <log_surgeon/finite_automata/Capture.hpp>
 #include <log_surgeon/finite_automata/TagOperation.hpp>
@@ -20,9 +23,6 @@
 #include <log_surgeon/types.hpp>
 #include <log_surgeon/UniqueIdGenerator.hpp>
 
-#include <fmt/format.h>
-#include <fmt/ranges.h>
-
 namespace log_surgeon::finite_automata {
 /**
  * Represents a Non-Deterministic Finite Automaton (NFA) designed to recognize a language based on

src/log_surgeon/finite_automata/NfaSpontaneousTransition.hpp

@@ -9,11 +9,11 @@
 #include <utility>
 #include <vector>
 
-#include <log_surgeon/finite_automata/TagOperation.hpp>
-
 #include <fmt/format.h>
 #include <fmt/ranges.h>
 
+#include <log_surgeon/finite_automata/TagOperation.hpp>
+
 namespace log_surgeon::finite_automata {
 /**
  * Represents an NFA transition with a collection of tag operations to be performed during the

src/log_surgeon/finite_automata/NfaState.hpp

@@ -13,16 +13,16 @@
 #include <utility>
 #include <vector>
 
+#include <fmt/format.h>
+#include <fmt/ranges.h>
+
 #include <log_surgeon/Constants.hpp>
 #include <log_surgeon/finite_automata/NfaSpontaneousTransition.hpp>
 #include <log_surgeon/finite_automata/StateType.hpp>
 #include <log_surgeon/finite_automata/TagOperation.hpp>
 #include <log_surgeon/finite_automata/UnicodeIntervalTree.hpp>
 #include <log_surgeon/types.hpp>
 
-#include <fmt/format.h>
-#include <fmt/ranges.h>
-
 namespace log_surgeon::finite_automata {
 template <StateType state_type>
 class NfaState;

src/log_surgeon/finite_automata/RegexAST.hpp

@@ -14,16 +14,16 @@
 #include <utility>
 #include <vector>
 
-#include <log_surgeon/Constants.hpp>
-#include <log_surgeon/finite_automata/Capture.hpp>
-#include <log_surgeon/finite_automata/TagOperation.hpp>
-#include <log_surgeon/finite_automata/UnicodeIntervalTree.hpp>
-
 #include <fmt/format.h>
 #include <fmt/ranges.h>
 #include <fmt/xchar.h>
 #include <gsl/pointers>
 
+#include <log_surgeon/Constants.hpp>
+#include <log_surgeon/finite_automata/Capture.hpp>
+#include <log_surgeon/finite_automata/TagOperation.hpp>
+#include <log_surgeon/finite_automata/UnicodeIntervalTree.hpp>
+
 namespace log_surgeon::finite_automata {
 template <typename TypedNfaState>
 class Nfa;

src/log_surgeon/finite_automata/RegisterOperation.hpp

@@ -5,10 +5,10 @@
 #include <optional>
 #include <string>
 
-#include <log_surgeon/types.hpp>
-
 #include <fmt/format.h>
 
+#include <log_surgeon/types.hpp>
+
 namespace log_surgeon::finite_automata {
 /**
  * Represents a register operation:

src/log_surgeon/finite_automata/TagOperation.hpp

@@ -5,10 +5,10 @@
 #include <string>
 #include <tuple>
 
-#include <log_surgeon/types.hpp>
-
 #include <fmt/format.h>
 
+#include <log_surgeon/types.hpp>
+
 namespace log_surgeon::finite_automata {
 enum class TagOperationType : uint8_t {
     Set,

src/log_surgeon/wildcard_query_parser/QueryInterpretation.cpp

@@ -6,12 +6,12 @@
 #include <variant>
 #include <vector>
 
-#include <log_surgeon/wildcard_query_parser/StaticQueryToken.hpp>
-#include <log_surgeon/wildcard_query_parser/VariableQueryToken.hpp>
-
 #include <fmt/format.h>
 #include <fmt/ranges.h>
 
+#include <log_surgeon/wildcard_query_parser/StaticQueryToken.hpp>
+#include <log_surgeon/wildcard_query_parser/VariableQueryToken.hpp>
+
 using std::string;
 using std::strong_ordering;
 using std::vector;

tests/test-schema.cpp

@@ -27,8 +27,8 @@ using RegexASTGroupByte
         = log_surgeon::finite_automata::RegexASTGroup<log_surgeon::finite_automata::ByteNfaState>;
 using RegexASTLiteralByte
         = log_surgeon::finite_automata::RegexASTLiteral<log_surgeon::finite_automata::ByteNfaState>;
-using RegexASTMultiplicationByte = log_surgeon::finite_automata::RegexASTMultiplication<
-        log_surgeon::finite_automata::ByteNfaState>;
+using RegexASTMultiplicationByte = log_surgeon::finite_automata::
+        RegexASTMultiplication<log_surgeon::finite_automata::ByteNfaState>;
 
 /**
  * @ingroup unit_tests_schema