fix(lint): Update to gersemi 0.21.0 and apply corresponding format changes. #69
Conversation
…g format changes.
WalkthroughThe changes update the syntax of the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
davidlion
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (2)
cmake/ystdlib-helpers.cmake(1 hunks)lint-requirements.txt(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: build-ystdlib-cpp (macos-14)
- GitHub Check: build-ystdlib-cpp (ubuntu-24.04)
- GitHub Check: lint-check (ubuntu-24.04)
🔇 Additional comments (1)
cmake/ystdlib-helpers.cmake (1)
106-114: LGTM – formatting-only consolidation, behaviour unchangedThe single-line
FILE_SET HEADERSkeeps semantics identical and aligns with the updated gersemi style. No further action needed.
| clang-tidy>=19.1.0 | ||
| colorama>=0.4.6 | ||
| gersemi>=0.20.0 | ||
| gersemi>=0.21.0 |
There was a problem hiding this comment.
🧹 Nitpick (assertive)
Consider pinning gersemi to a specific patch version for deterministic CI results
Using a permissive constraint (>=0.21.0) means the next patch/minor release could silently change formatting rules and break the pipeline again. Locking to an exact version (e.g., ==0.21.0) or using ~= to stay within the same minor line gives more predictable builds while still allowing conscious upgrades.
🤖 Prompt for AI Agents
In lint-requirements.txt at line 4, the version constraint for gersemi is
currently set to a permissive ">=0.21.0". To ensure deterministic CI results and
avoid unexpected breakages from patch or minor updates, change this to a more
restrictive version specifier such as "==0.21.0" to pin to an exact version or
"~=0.21.0" to allow only patch updates within the same minor version.
2 participants
Description
Recently, the linting CI is failing due to a new version of gersemi requiring code formatting changes (e.g. https://github.com/y-scope/ystdlib-cpp/actions/runs/16486323490/job/46611599923#step:5:16870). This PR applies the change and also bumps the version in
lint-requirements.txtto reflect the latest version.This version of gersemi appears to revert the change they introduced in #68.
Checklist
breaking change.
Validation performed
CI and gersemi passing.
Summary by CodeRabbit
gersemipackage in the linting dependencies.