Skip to content

fix(lint): Update to gersemi 0.21.0 and apply corresponding format changes. #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 24, 2025
Merged

fix(lint): Update to gersemi 0.21.0 and apply corresponding format changes. #69

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions cmake/ystdlib-helpers.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,8 +106,7 @@ function(add_cpp_library)
target_sources(
${ARG_NAME}
PUBLIC
FILE_SET
HEADERS
FILE_SET HEADERS
BASE_DIRS
"$<BUILD_INTERFACE:${ARG_BUILD_INCLUDE_DIRS}>"
"$<INSTALL_INTERFACE:${CMAKE_INSTALL_INCLUDEDIR}>"
Expand Down
2 changes: 1 addition & 1 deletion lint-requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
clang-format>=20.1.0
clang-tidy>=19.1.0
colorama>=0.4.6
gersemi>=0.20.0
gersemi>=0.21.0
Copy link

@coderabbitai coderabbitai bot Jul 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick (assertive)

Consider pinning gersemi to a specific patch version for deterministic CI results

Using a permissive constraint (>=0.21.0) means the next patch/minor release could silently change formatting rules and break the pipeline again. Locking to an exact version (e.g., ==0.21.0) or using ~= to stay within the same minor line gives more predictable builds while still allowing conscious upgrades.

🤖 Prompt for AI Agents 
In lint-requirements.txt at line 4, the version constraint for gersemi is
currently set to a permissive ">=0.21.0". To ensure deterministic CI results and
avoid unexpected breakages from patch or minor updates, change this to a more
restrictive version specifier such as "==0.21.0" to pin to an exact version or
"~=0.21.0" to allow only patch updates within the same minor version.

yamllint>=1.35.1