Skip to content

[Disk Manager] Add context handling in collectListerMetricsTask #4633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 10, 2025
Merged

[Disk Manager] Add context handling in collectListerMetricsTask #4633

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a792b8d
[Disk Manager] Add context handling in collectListerMetricsTask
jkuradobery Nov 7, 2025
e865351
Fix
jkuradobery Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 22 additions & 19 deletions cloud/tasks/collect_lister_metrics_task.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,30 +51,33 @@ func (c *collectListerMetricsTask) Run(
ticker := time.NewTicker(c.metricsCollectionInterval)
defer ticker.Stop()

for range ticker.C {
for _, taskStatus := range taskStatuses {
err := c.collectTasksMetrics(
ctx,
func(context.Context) ([]storage.TaskInfo, error) {
return c.storage.ListTasksWithStatus(
ctx,
taskStatus,
)
},
taskStatus,
)
for {
select {
case <-ctx.Done():
return ctx.Err()
case <-ticker.C:
for _, taskStatus := range taskStatuses {
err := c.collectTasksMetrics(
ctx,
func(context.Context) ([]storage.TaskInfo, error) {
return c.storage.ListTasksWithStatus(
ctx,
taskStatus,
)
},
taskStatus,
)
if err != nil {
return err
}
}

err := c.collectHangingTasksMetrics(ctx)
if err != nil {
return err
}
}

err := c.collectHangingTasksMetrics(ctx)
if err != nil {
return err
}
}

return nil
}

func (c *collectListerMetricsTask) Cancel(
Expand Down
Loading