feat: restrictions for not IsViewerUser #2684
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raubzeug
requested review from
adameat,
artemmufazalov and
astandrik
as code owners
artemmufazalov
requested changes
Aug 8, 2025
Comment on lines
245
to
247
| const vDiskExtendedParamsDefined = !isNil(nodeId) && !isNil(pDiskId) && !isNil(vDiskSlotId); | ||
|
|
||
| const vDiskBasicParamsDefined = !isNil(vDiskId); |
There was a problem hiding this comment.
Looks like you may leave only !isNil(vDiskId), I don't see why you the rest params are necessary if you have a check vDiskExtendedParamsDefined || vDiskBasicParamsDefined
artemmufazalov
previously approved these changes
Aug 8, 2025
|
/claude-review |
artemmufazalov
approved these changes
Aug 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stand
Decided with @adameat to user
/groupshandler to get information about vDisk, cause this handler is effective and support all security issues.CI Results
Test Status:⚠️ FLAKY
📊 Full Report
Test Changes Summary ⏭️2
⏭️ Skipped Tests (2)
Bundle Size: 🔺
Current: 85.33 MB | Main: 85.32 MB
Diff: +8.42 KB (0.01%)
ℹ️ CI Information