fix(Network): correctly pass database in peer role #2831
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemmufazalov
requested review from
Raubzeug,
adameat and
astandrik
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue with passing the database parameter when handling peer role filters in the Network section. The changes ensure that the peer role filter is conditionally applied and correctly defaults to 'database' when appropriate.
- Updates the
useNodesPageQueryParamshook to accept awithPeerRoleFilterparameter for conditional peer role filtering - Modifies
parseNodesPeerRoleFilterto support a default value parameter - Updates all callers to pass the new
withPeerRoleFilterparameter
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/containers/Nodes/useNodesPageQueryParams.ts | Added withPeerRoleFilter parameter and conditional peer role logic with database default |
| src/containers/Nodes/PeerRoleFilter/utils.tsx | Added defaultValue parameter to parseNodesPeerRoleFilter function |
| src/containers/Nodes/PaginatedNodes/PaginatedNodes.tsx | Updated useNodesPageQueryParams call to include withPeerRoleFilter prop |
| src/containers/Nodes/PaginatedNodes/NodesComponent.tsx | Updated useNodesPageQueryParams call to include withPeerRoleFilter prop |
| src/containers/Nodes/PaginatedNodes/GroupedNodesComponent.tsx | Updated useNodesPageQueryParams call to include withPeerRoleFilter prop |
| src/containers/Nodes/NodesControls/NodesControls.tsx | Updated useNodesPageQueryParams call to include withPeerRoleFilter prop |
Raubzeug
approved these changes
Sep 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI Results
Test Status:⚠️ FLAKY
📊 Full Report
Test Changes Summary ⏭️2
⏭️ Skipped Tests (2)
Bundle Size: ✅
Current: 85.39 MB | Main: 85.39 MB
Diff: +0.36 KB (0.00%)
✅ Bundle size unchanged.
ℹ️ CI Information