feat: support system view #2899
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemmufazalov
force-pushed
the
2589-support-system-views
branch
from
2ba9f6a to
9c0016c
Compare
artemmufazalov
force-pushed
the
2589-support-system-views
branch
from
9c0016c to
1ca2e2b
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds first-class support for “System view” entities across types, schema visualization, diagnostics pages, and summary/info panels.
- Introduces a new EPathTypeSysView and TSysViewDescription types and wires them into existing mappings.
- Extends SchemaViewer (data + columns) and Diagnostics pages to render System views similarly to row tables.
- Adds UI labels and info panel for System view type.
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/utils/schema.ts | Adds prepareSystemViewType to format ESysViewType for display. |
| src/types/api/schema/sysView.ts | Introduces TSysViewDescription and ESysViewType union. |
| src/types/api/schema/schema.ts | Adds SysViewDescription to TPathDescription and EPathTypeSysView. |
| src/containers/Tenant/utils/schema.ts | Maps EPathTypeSysView to node type, entity name, and boolean classifiers. |
| src/containers/Tenant/Schema/SchemaViewer/prepareData.ts | Treats System view like a row table for schema preparation. |
| src/containers/Tenant/Schema/SchemaViewer/columns.tsx | Adds getSystemViewColumns. |
| src/containers/Tenant/Schema/SchemaViewer/SchemaViewer.tsx | Chooses System view columns when type is EPathTypeSysView. |
| src/containers/Tenant/ObjectSummary/i18n/en.json | Adds i18n key for “System view type” in Object Summary. |
| src/containers/Tenant/ObjectSummary/ObjectSummary.tsx | Shows System view type in summary via prepareSystemViewType. |
| src/containers/Tenant/Info/i18n/en.json | Adds i18n keys for System view info panel and generic “no data” message. |
| src/containers/Tenant/Info/SystemView/SystemView.tsx | New info panel for System view with type display. |
| src/containers/Tenant/Diagnostics/Overview/Overview.tsx | Renders SystemViewInfo in Overview for system views. |
| src/containers/Tenant/Diagnostics/DiagnosticsPages.ts | Defines SYSTEM_VIEW_PAGES and maps EPathTypeSysView to these pages. |
artemmufazalov
force-pushed
the
2589-support-system-views
branch
from
9d166f1 to
0ce0656
Compare
artemmufazalov
requested review from
Raubzeug,
adameat and
astandrik
as code owners
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
astandrik
reviewed
Sep 19, 2025
| if (!type) { | ||
| return undefined; | ||
| } | ||
| if (type.startsWith('E')) { |
There was a problem hiding this comment.
That looks fragile - would be great if you left some comment what and why is 'E'
astandrik
reviewed
Sep 19, 2025
| const entityName = getEntityName(data?.PathDescription); | ||
|
|
||
| if (!data) { | ||
| return <div className="error">{i18n('no-entity-data', {entityName})}</div>; |
There was a problem hiding this comment.
As far as I know we use b() for classes usually
There was a problem hiding this comment.
Replaced with <Text color='danger'>
astandrik
previously approved these changes
Sep 19, 2025
astandrik
approved these changes
Sep 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2589
Stand: https://nda.ya.ru/t/dghhH4d_7K8SVn
CI Results
Test Status:⚠️ FLAKY
📊 Full Report
Test Changes Summary ⏭️2
⏭️ Skipped Tests (2)
Bundle Size: 🔺
Current: 85.40 MB | Main: 85.39 MB
Diff: +7.11 KB (0.01%)
ℹ️ CI Information
Updated On: 2025-09-19 09:23:03 UTC
This PR introduces comprehensive support for YDB system views throughout the embedded UI. System views are dynamically generated database objects that provide access to system information (like partition statistics, node data, query metrics) and differ fundamentally from regular tables - they don't have physical storage, partitions, or tablets since data is computed on-the-fly.
The implementation adds a new path type
EPathTypeSysViewto the schema system and creates dedicated UI components for displaying system view information. Key changes include:TSysViewDescriptioninterface and comprehensiveESysViewTypeunion type covering 34 different system view typesSystemViewInfocomponent displays system view metadata, andObjectSummaryshows system view type informationThe changes follow existing architectural patterns by extending type mappings, column configurations, and component routing to handle the new entity type. The implementation leverages the existing
prepareRowTableSchemafunction for system views since they share similar column structure characteristics with row tables.Important Files Changed
Changed Files
Confidence score: 4/5
Sequence Diagram
sequenceDiagram participant User participant DiagnosticsPages participant Overview participant overviewApi participant SystemViewInfo participant ObjectSummary participant SchemaViewer User->>DiagnosticsPages: "Navigate to system view" DiagnosticsPages->>DiagnosticsPages: "getPagesByType(EPathTypeSysView)" DiagnosticsPages->>DiagnosticsPages: "Returns SYSTEM_VIEW_PAGES" User->>Overview: "View system view overview" Overview->>overviewApi: "useGetOverviewQuery({path, database, databaseFullPath})" overviewApi-->>Overview: "Returns system view data" Overview->>Overview: "pathTypeToComponent[EPathTypeSysView]" Overview->>SystemViewInfo: "Render SystemViewInfo component" SystemViewInfo->>SystemViewInfo: "prepareSystemViewItems(data)" SystemViewInfo->>SystemViewInfo: "prepareSystemViewType(systemViewType)" SystemViewInfo-->>Overview: "YDBDefinitionList with system view type" User->>ObjectSummary: "View system view summary" ObjectSummary->>ObjectSummary: "getPathTypeOverview[EPathTypeSysView]()" ObjectSummary->>ObjectSummary: "prepareSystemViewType(PathDescription?.SysViewDescription?.Type)" ObjectSummary-->>User: "Display system view type field" User->>SchemaViewer: "View system view schema" SchemaViewer->>SchemaViewer: "isSystemViewType(type)" SchemaViewer->>SchemaViewer: "prepareSchemaData(type, tableSchemaData)" SchemaViewer->>SchemaViewer: "getSystemViewColumns(tableData)" SchemaViewer-->>User: "Display system view columns with id, name, type, notNull"Context used:
Style Guide - description of repository for agents (link)