Skip to content

fix: dont render network tab for clusters without network #2905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 19, 2025
Merged

fix: dont render network tab for clusters without network #2905

merged 2 commits into from
Sep 19, 2025

Conversation

@astandrik
Copy link
Collaborator

@astandrik astandrik commented Sep 19, 2025 •
edited by github-actions bot
Loading

Closes #2904

CI Results

Test Status: ⚠️ FLAKY

📊 Full Report

Total Passed Failed Flaky Skipped
378 373 0 3 2
Test Changes Summary ⏭️2

⏭️ Skipped Tests (2)

  1. Scroll to row, get shareable link, navigate to URL and verify row is scrolled into view (tenant/diagnostics/tabs/queries.test.ts)
  2. Copy result button copies to clipboard (tenant/queryEditor/queryEditor.test.ts)

Bundle Size: ✅

Current: 85.39 MB | Main: 85.39 MB
Diff: 0.07 KB (-0.00%)

✅ Bundle size unchanged.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

@astandrik astandrik added this pull request to the merge queue Sep 19, 2025
Merged via the queue into main with commit dc7e723 Sep 19, 2025
7 checks passed
@astandrik astandrik deleted the astandrik.2904 branch September 19, 2025 11:21
@ydb-platform-bot ydb-platform-bot mentioned this pull request Sep 19, 2025
Merged
artemmufazalov pushed a commit that referenced this pull request Sep 23, 2025
@astandrik @artemmufazalov
fix: dont render network tab for clusters without network (#2905)
a4cb568
@ydb-platform-bot ydb-platform-bot mentioned this pull request Sep 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@artemmufazalov artemmufazalov artemmufazalov approved these changes

@Raubzeug Raubzeug Awaiting requested review from Raubzeug Raubzeug is a code owner

@adameat adameat Awaiting requested review from adameat adameat is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

fix: dont render network tab for clusters without network

3 participants

@astandrik @artemmufazalov