Skip to content

fix: dont render network tab for clusters without network #2905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 19, 2025
Merged

fix: dont render network tab for clusters without network #2905

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
93a0581
fix: dont render network tab for clusters without network
astandrik Sep 19, 2025
180c63d
fix: better code
astandrik Sep 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/containers/Tenant/Diagnostics/TenantOverview/MetricsTabs/MetricsTabs.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,16 @@ export function MetricsTabs({
return null;
}

const canShow =
networkUtilization !== undefined &&
networkThroughput !== undefined &&
isFinite(networkUtilization) &&
isFinite(networkThroughput);

if (!canShow) {
return null;
}

if (isServerless) {
return <PlaceholderTab />;
}
Expand Down
17 changes: 2 additions & 15 deletions src/containers/Tenant/Diagnostics/TenantOverview/MetricsTabs/components/NetworkTab.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,31 +5,18 @@ import {cn} from '../../../../../../utils/cn';
import {UtilizationTabCard} from '../../TabCard/UtilizationTabCard';
import i18n from '../../i18n';

import {PlaceholderTab} from './PlaceholderTab';

import '../MetricsTabs.scss';

const b = cn('tenant-metrics-tabs');

interface NetworkTabProps {
to: string;
active: boolean;
networkUtilization?: number;
networkThroughput?: number;
networkUtilization: number;
networkThroughput: number;
}

export function NetworkTab({to, active, networkUtilization, networkThroughput}: NetworkTabProps) {
const canShow =
networkUtilization !== undefined &&
networkThroughput !== undefined &&
isFinite(networkUtilization) &&
isFinite(networkThroughput) &&
networkThroughput > 0;

if (!canShow) {
return <PlaceholderTab />;
}

const fillPercent = networkUtilization * 100;
const legendText = formatBytes({value: networkThroughput, withSpeedLabel: true});

Expand Down
Loading