fix(HoverPopup): prevent untimely closing #2926
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raubzeug
requested review from
adameat,
artemmufazalov and
astandrik
as code owners
| onHidePopup={onHidePopup} | ||
| renderPopupContent={() => <VDiskPopup data={data} />} | ||
| offset={{mainAxis: 5, crossAxis: 0}} | ||
| offset={{mainAxis: 2, crossAxis: 0}} |
There was a problem hiding this comment.
Please, explain, how your changes make everything better? I see no difference
There was a problem hiding this comment.
The main difference is that YDB_POPOVER_CLASS_NAME is now applied not to the popup itself, but to its content. Previously, when paddings were set at the popup level, the popup would close when the mouse hovered over these paddings. Now, paddings are part of the content, so the popup no longer closes prematurely.
I also made some minor adjustments to the offsets, but that's not the main improvement.
artemmufazalov
approved these changes
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2787
Stand
CI Results
Test Status:⚠️ FLAKY
📊 Full Report
Test Changes Summary ⏭️2
⏭️ Skipped Tests (2)
Bundle Size: ✅
Current: 85.37 MB | Main: 85.37 MB
Diff: +0.04 KB (0.00%)
✅ Bundle size unchanged.
ℹ️ CI Information