Skip to content

fix(HoverPopup): prevent untimely closing #2926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 25, 2025
Merged

fix(HoverPopup): prevent untimely closing #2926

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/components/HoverPopup/HoverPopup.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,6 @@ export const HoverPopup = ({
// bigger offset for easier switching to neighbour nodes
// matches the default offset for popup with arrow out of a sense of beauty
offset={offset || {mainAxis: 12, crossAxis: 0}}
className={YDB_POPOVER_CLASS_NAME}
>
<div
className={contentClassName}
Expand All @@ -117,7 +116,7 @@ export const HoverPopup = ({
onMouseLeave={onPopupMouseLeave}
onBlur={onPopupBlur}
>
{renderPopupContent()}
<div className={YDB_POPOVER_CLASS_NAME}>{renderPopupContent()}</div>
</div>
</Popup>
) : null}
Expand Down
2 changes: 1 addition & 1 deletion src/components/VDisk/VDisk.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ export const VDisk = ({
onShowPopup={onShowPopup}
onHidePopup={onHidePopup}
renderPopupContent={() => <VDiskPopup data={data} />}
offset={{mainAxis: 5, crossAxis: 0}}
offset={{mainAxis: 2, crossAxis: 0}}
Copy link
Member

@artemmufazalov artemmufazalov Sep 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, explain, how your changes make everything better? I see no difference

Copy link
Contributor Author

@Raubzeug Raubzeug Sep 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main difference is that YDB_POPOVER_CLASS_NAME is now applied not to the popup itself, but to its content. Previously, when paddings were set at the popup level, the popup would close when the mouse hovered over these paddings. Now, paddings are part of the content, so the popup no longer closes prematurely.
I also made some minor adjustments to the offsets, but that's not the main improvement.

delayClose={delayClose}
delayOpen={delayOpen}
>
Expand Down
2 changes: 1 addition & 1 deletion src/containers/Storage/PDisk/PDisk.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ export const PDisk = ({
{renderVDisks()}
<HoverPopup
showPopup={showPopup}
offset={{mainAxis: 5, crossAxis: 0}}
offset={{mainAxis: 2, crossAxis: 0}}
anchorRef={anchorRef}
onShowPopup={onShowPopup}
onHidePopup={onHidePopup}
Expand Down
Loading