Fix missing strategies by rossgalloway · Pull Request #1056 · yearn/yearn.fi

rossgalloway · 2026-02-07T16:48:14Z

Summary

This branch improves vault ingestion, holdings detection, and holdings valuation consistency across portfolio and vault list flows.

Key outcome: user-held vault positions are now reliably surfaced even when they are not in the main catalog or not tagged as Yearn (including retired/migrated/staking-edge cases), and USD holdings values are computed from a single shared path.

Commits Included

b37abe0 chore(audit): add kong vault inclusion audit script
12ed3e8 feat(vaults): fetch full kong list and expose catalog/all vault maps
3a9ee99 feat(vault-filters): include user-held vaults from allVaults
f0c394d feat(holdings): unify vault holdings usd calculation and consumers
7b50665 fix(balances): restrict enso missing-token fallback to vault position tokens
77e3187 fix(format): make toBigInt robust to scientific notation
e1f8816 fix: staking holdings detection for non-zero staking addresses

Added audit:kong-vault-inclusion script (scripts/audit-kong-vault-inclusion.ts) to inspect why specific vaults are/aren’t included.
- allVaults (full mapped set by chain filter)
- vaults (catalog set where origin=yearn or inclusion.isYearn=true)
Extended Kong schema/mapping:
- normalized/mapped PPS into vault.apr.pricePerShare.today
Updated V2/V3 vault filters to include user-held vaults from allVaults via raw balance checks (vault share or staking token).
Adjusted filter behavior so user-held positions are not hidden by chain/type/category/aggressiveness/underlying/minTVL filters.
Centralized USD holdings computation in getVaultHoldingsUsdValue and reused it in:
- portfolio model
- wallet cumulative V2/V3 totals
- vault list holdings chip
- deposited sorting
Marked yearn token entries with for: 'vault-share' | 'vault-staking' and included staking tokens by non-zero address.
Restricted Enso missing-token multicall fallback to vault position tokens only, with deduped fallback token list.
Final consistency fix: staking holdings now use non-zero staking address checks (not staking.available) in portfolio lookup and raw-holdings checks.

How To Test

Automated

bun run lint
bun run tslint
bun run audit:kong-vault-inclusion -- --chain 1 0x7A26C6c1628c86788526eFB81f37a2ffac243A98 0xf91a9A1C782a1C11B627f6E576d92C7d72CDd4AF. These do not show in the old branch but should in the new.

Manual

Use a wallet with holdings in a vault that is not in the active catalog (retired/migrated/non-catalog).
Confirm holdings appear in portfolio and vault lists (V2/V3), and are not dropped by filters.
Apply strict filters (chain/type/category/aggressiveness/underlying/minTVL) and verify held positions remain visible.
Verify “deposited” sort order and holdings chip value match portfolio totals for the same vault.
Test a staked-only position where staking.available=false but staking address is non-zero:
- position is included in holdings
- value is included in totals

vercel · 2026-02-07T16:48:19Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
yearnfi	Ready	Preview, Comment	Feb 19, 2026 3:59pm

github-actions · 2026-02-07T16:48:23Z

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

github-actions · 2026-02-07T16:48:24Z

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

murderteeth

unless urgent lets chat on this during standup

rossgalloway · 2026-02-09T19:23:59Z

Some additional fixes:

To fix an issue where any ERC4626 vault was included in the portfolio list, PR 1056 now separates Yearn vault identity into two explicit buckets:

Catalog list (vaults): only origin === 'yearn'.
Holdings fallback (inclusionYearnVaults): only inclusion.isYearn === true.

All user holdings paths (V2/V3 held vault inclusion, portfolio holdings lookup, and wallet cumulative holdings totals)
now use the union of those two sets, so holdings are included when origin === 'yearn' || inclusion.isYearn === true,
while non-Yearn ERC4626 vaults are excluded.

Also included: a staking edge-case fix so staked-only positions are detected by non-zero staking address (not
staking.available). Lint and typecheck pass.

0xeye

Just a couple styling/use-case comments, otherwise LGTM

0xeye · 2026-02-09T19:31:17Z

scripts/audit-kong-vault-inclusion.ts

Is this needed often in future use-cases? If not, maybe remove. Can always pull back script from PR if needed at a later date?

yep, can remove

0xeye · 2026-02-09T19:32:15Z

src/components/shared/contexts/useWallet.tsx

+    for (const [vaultAddress, vault] of Object.entries(yearnHoldingsVaults)) {
      if (vault.staking?.address && !isZeroAddress(toAddress(vault.staking.address))) {
        stakingToVault.set(toAddress(vault.staking.address), vaultAddress)
      }


Would prefer for the for and let on the files this PR touches to be swapped to functional use cases (know it wasn't beforehand, but it caught my attention hah). Generally makes it easier to understand state changes & why they're happening

rossgalloway · 2026-02-09T20:24:40Z

unless urgent lets chat on this during standup

I think we should include this change AND make sure Kong is correctly classifying vaults and strategies as yearn when they should be.

Doing the fetch as this PR proposes will allow us to also allow deposits and withdrawals to any ERC-4626 vault be navigating directly to that address. ~~Although I am realizing I should add a warning if a vault is not a yearn vault.~~ Warning added for non yearn vaults.

* feat: dedupe reused code * chore: remove deadcode * chore: lock and loaded * chore: bump

* Fix: incorrect route error on factory vault deposit (#1055) * fix error with factory vault showing unavailable route on deposit * fix issue in review --------- Co-authored-by: Ross <ross@yearn.finance> * add automatic deposit pop-up --------- Co-authored-by: Ross <ross@yearn.finance>

* Fix: incorrect route error on factory vault deposit (#1055) * fix error with factory vault showing unavailable route on deposit * fix issue in review --------- Co-authored-by: Ross <ross@yearn.finance> * remove kong to ydaemon shape mapping --------- Co-authored-by: Ross <ross@yearn.finance>

…1063)

… tokens

* fix breadcrumbs * styling and lint * fix spacing --------- Co-authored-by: Ross <ross@yearn.finance>

* Fix: improve number display * chore: fix linting --------- Co-authored-by: 0xeye <97349378+0xeye@users.noreply.github.com>

BlinkyStitt · 2026-03-01T17:38:01Z

I'm really looking forward to having this!

rossgalloway · 2026-03-12T14:57:34Z

this is incorporated in #1093

rossgalloway requested review from 0xeye and murderteeth February 7, 2026 16:48

murderteeth reviewed Feb 9, 2026

View reviewed changes

vercel bot deployed to Preview – yearnfi February 9, 2026 19:26 View deployment

0xeye requested changes Feb 9, 2026

View reviewed changes

vercel bot deployed to Preview – yearnfi February 9, 2026 20:25 View deployment

vercel bot deployed to Preview – yearnfi February 9, 2026 22:22 View deployment

vercel bot deployed to Preview – yearnfi February 9, 2026 22:24 View deployment

0xeye and others added 3 commits February 10, 2026 10:32

chore: init

fcda410

chore: cleanup (#1053)

71adc6e

* feat: dedupe reused code * chore: remove deadcode * chore: lock and loaded * chore: bump

rossgalloway changed the base branch from main to dev February 10, 2026 18:01

rossgalloway and others added 13 commits February 13, 2026 09:58

feat: improve search result filtering behavior and misc other fixes (#…

8061725

…1063)

chore(audit): add kong vault inclusion audit script

78a9b7d

feat(vaults): fetch full kong list and expose catalog/all vault maps

879b350

feat(vault-filters): include user-held vaults from allVaults

07a9790

feat(holdings): unify vault holdings usd calculation and consumers

b76ad3d

fix(balances): restrict enso missing-token fallback to vault position…

4766337

… tokens

fix(format): make toBigInt robust to scientific notation

4688627

Fix staking holdings detection for non-zero staking addresses

e36616e

fix filtering logic to filter non-yearn erc-4626 on portfolio page

d434cea

fix: make code functional and remove script

78424a0

add warning for non-yearn-endorsed vaults

7a73e96

fix strategies panel regression

2fb0e41

fix regression in portfolio display

7a639ba

rossgalloway force-pushed the fix--missing-strategies branch from 0d25e1c to 7a639ba Compare February 18, 2026 17:42

vercel bot had a problem deploying to Preview – yearnfi February 18, 2026 17:43 Failure

Ross added 2 commits February 18, 2026 12:19

fix additional regressions and issues

4e0e8d9

fix issue with balance display in portfolio page

021aff2

vercel bot had a problem deploying to Preview – yearnfi February 18, 2026 19:56 Failure

fix test to get build working

c7bf7ca

vercel bot deployed to Preview – yearnfi February 18, 2026 20:05 View deployment

lint

5806a41

vercel bot deployed to Preview – yearnfi February 18, 2026 20:12 View deployment

0xeye and others added 4 commits February 19, 2026 06:09

feat: update CLAUDE.md

cc44fc7

chore: fix sticky on portfolio (#1072)

00d7e1d

* fix breadcrumbs * styling and lint * fix spacing --------- Co-authored-by: Ross <ross@yearn.finance>

chore: fix vault widget numbers display size and readability (#1070)

1fe99f4

* Fix: improve number display * chore: fix linting --------- Co-authored-by: 0xeye <97349378+0xeye@users.noreply.github.com>

Merge branch 'dev' into fix--missing-strategies

5fa32b4

vercel bot deployed to Preview – yearnfi February 19, 2026 15:59 View deployment

0xeye force-pushed the dev branch from 8835dbe to d794b36 Compare February 26, 2026 13:16

Base automatically changed from dev to main February 26, 2026 15:06

This was referenced Mar 6, 2026

Fix Staked assets not showing up and not being withdrawable #1089

Closed

fix: rebuild staking withdraw path on release #1103

Closed

rossgalloway closed this Mar 12, 2026

Conversation

rossgalloway commented Feb 7, 2026

Summary

Commits Included

How To Test

Automated

Manual

Uh oh!

vercel bot commented Feb 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Dependency Review

Scanned Files

Uh oh!

github-actions bot commented Feb 7, 2026

Dependency Review

Scanned Files

Uh oh!

murderteeth left a comment

Choose a reason for hiding this comment

Uh oh!

rossgalloway commented Feb 9, 2026

Uh oh!

0xeye left a comment

Choose a reason for hiding this comment

Uh oh!

0xeye Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

rossgalloway Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

0xeye Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

rossgalloway Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

rossgalloway commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BlinkyStitt commented Mar 1, 2026

Uh oh!

rossgalloway commented Mar 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

vercel bot commented Feb 7, 2026 •

edited

Loading

github-actions bot commented Feb 7, 2026 •

edited

Loading

rossgalloway commented Feb 9, 2026 •

edited

Loading