Skip to content

feat: Remove batcher_url parameter + better network parameter #1730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
uri-99 merged 33 commits into from
Jan 17, 2025
Merged

feat: Remove batcher_url parameter + better network parameter #1730

uri-99 merged 33 commits into from
Jan 17, 2025

Conversation

@PatStiles
Copy link
Contributor

@PatStiles PatStiles commented Jan 10, 2025 •
edited by JuArce
Loading

Remove batcher_url parameter + better network parameter

Description

This PR removes the --batcher_url parameter from the CLI + SDK + task sender.

Now, all values are derived from the --network parameter, which now also accepts a --network custom <service_manager> <batcher_payments> <batcher_url> value, to set these values.

In this PR we also fixed a wrong "batch will be lost" error message.

Type of change

Please delete options that are not relevant.

  • New feature
  • Refactor

Checklist

  • “Hotfix” to testnet, everything else to staging
  • Linked to Github Issue
  • This change depends on code or research by an external entity
    • Acknowledgements were updated to give credit
  • Unit tests added
  • This change requires new documentation.
    • Documentation has been added/updated.
  • This change is an Optimization
    • Benchmarks added/run
  • Has a known issue
  • If your PR changes the Operator compatibility (Ex: Upgrade prover versions)
    • This PR adds compatibility for operator for both versions and do not change batcher/docs/examples
    • This PR updates batcher and docs/examples to the newer version. This requires the operator are already updated to be compatible

@PatStiles PatStiles changed the base branch from testnet to staging January 10, 2025 18:07
@PatStiles PatStiles self-assigned this Jan 10, 2025
@PatStiles PatStiles marked this pull request as draft January 10, 2025 18:07
@uri-99 uri-99 mentioned this pull request Jan 15, 2025
Closed
14 tasks
@uri-99 uri-99 changed the title feat(cli): Deprecate Batcher URL feat: Deprecate Batcher URL Jan 15, 2025
@uri-99 uri-99 changed the title feat: Deprecate Batcher URL feat: Remove batcher_url parameter + beter network parameter Jan 15, 2025
uri-99
uri-99 suggested changes Jan 15, 2025
View reviewed changes
@uri-99 uri-99 marked this pull request as ready for review January 15, 2025 22:09
@uri-99 uri-99 changed the title feat: Remove batcher_url parameter + beter network parameter feat: Remove batcher_url parameter + better network parameter Jan 16, 2025
@uri-99 uri-99 self-assigned this Jan 16, 2025
@uri-99 uri-99 mentioned this pull request Jan 16, 2025
Merged
14 tasks
@uri-99 uri-99 changed the base branch from staging to pull_fixes_testnet_17_01 January 17, 2025 20:22
Base automatically changed from pull_fixes_testnet_17_01 to staging January 17, 2025 21:11
JuArce
JuArce approved these changes Jan 17, 2025
View reviewed changes
@uri-99 uri-99 added this pull request to the merge queue Jan 17, 2025
Merged via the queue into staging with commit 0525847 Jan 17, 2025
3 checks passed
@uri-99 uri-99 deleted the feat/deprecate-batcher-url branch January 17, 2025 23:05
@JuArce JuArce mentioned this pull request Mar 20, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JuArce JuArce JuArce approved these changes

+2 more reviewers

@Oppen Oppen Oppen approved these changes

@uri-99 uri-99 uri-99 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@PatStiles PatStiles

@uri-99 uri-99

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@PatStiles @Oppen @uri-99 @JuArce