Skip to content

Conversation

@PatStiles
Copy link
Contributor

Add slack alerts for task submission sender

Description

Detects error messages logged returned from when the task sender sends proofs and sends them as separate slack messages to the slack alerts channel.

To Test:

  • start a local devnet
  • Specify a PRIVATE_KEY and SENDER_ADDRESS in ./alerts/.env that does not have a batcher balance to trigger InsufficientBalance Errors
  • execute the alert script via ./alerts/sender_with_alert.sh ./alerts/.env
    You should observe that the error messages printed in the slack alerts channel as follows:
Error submitting proof to devnet:  Batcher responded with insufficient balance

Type of change

Please delete options that are not relevant.

  • New feature

Checklist

  • “Hotfix” to testnet, everything else to staging
  • Linked to Github Issue
  • This change depends on code or research by an external entity
    • Acknowledgements were updated to give credit
  • Unit tests added
  • This change requires new documentation.
    • Documentation has been added/updated.
  • This change is an Optimization
    • Benchmarks added/run
  • Has a known issue
  • If your PR changes the Operator compatibility (Ex: Upgrade prover versions)
    • This PR adds compatibility for operator for both versions and do not change batcher/docs/examples
    • This PR updates batcher and docs/examples to the newer version. This requires the operator are already updated to be compatible

Copy link
Member

@MarcosNicolau MarcosNicolau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine, testing slack notifications and I'll approve it.

@uri-99 uri-99 requested a review from JuArce January 17, 2025 21:14
@JuArce JuArce self-assigned this Jan 21, 2025
@uri-99 uri-99 merged commit 21a3806 into testnet Jan 22, 2025
1 check passed
@uri-99 uri-99 deleted the hotfix/task_sender_error_alerts branch January 22, 2025 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants