Skip to content

feat(alerts): Add slack alerts for task submission sender #1734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
uri-99 merged 10 commits into from
Jan 22, 2025
Merged

feat(alerts): Add slack alerts for task submission sender #1734

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
568d2ae
add error alerts
PatStiles Jan 13, 2025
e31e435
displays number of verified proofs + fix devnet aligned service manag…
PatStiles Jan 13, 2025
5ac38d9
nits
PatStiles Jan 13, 2025
ac3b937
Merge branch 'testnet' into hotfix/task_sender_error_alerts
MarcosNicolau Jan 14, 2025
46a885a
feat: dont run if failed connection
uri-99 Jan 16, 2025
ed53864
chore: style
uri-99 Jan 16, 2025
ac1da71
Merge commit 'eabda9c7a2c8c538843443128d187e02f49b61b9' into hotfix/t…
uri-99 Jan 17, 2025
6c6f745
fix: revert removal of remove proof data
uri-99 Jan 17, 2025
d477750
Merge branch 'testnet' into hotfix/task_sender_error_alerts
JuArce Jan 21, 2025
da5aff6
fix: retry send tasks in case of error and send notification to slack
JuArce Jan 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions alerts/sender_with_alert.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,10 +85,6 @@ function send_slack_message() {
while true
do

## Remove Proof Data
rm -rf ./scripts/test_files/gnark_groth16_bn254_infinite_script/infinite_proofs/*
rm -rf ./aligned_verification_data/*

mkdir -p ./scripts/test_files/gnark_groth16_bn254_infinite_script/infinite_proofs

## Generate Proof
Expand All @@ -114,6 +110,16 @@ do
2>&1)

echo "$submit"

submit_errors=$(echo "$submit" | grep -oE 'ERROR[^]]*]([^[]*)' | sed 's/^[^]]*]//;s/[[:space:]]*$//')

# Loop through each error found and print with the custom message
while IFS= read -r error; do
if [[ -n "$error" ]]; then
slack_error_message="Error submitting proof to $NETWORK: $error"
send_slack_message "$slack_error_message"
fi
done <<< "$submit_errors"

echo "Waiting $VERIFICATION_WAIT_TIME seconds for verification"
sleep $VERIFICATION_WAIT_TIME
Expand Down Expand Up @@ -164,7 +170,7 @@ do
spent_amount_usd=$(echo "$spent_amount * $eth_usd" | bc | awk '{printf "%.2f", $1}')

slack_messsage=""
verified=1
verified=0

## Verify Proofs
echo "Verifying $REPETITIONS proofs $x != 0"
Expand All @@ -181,9 +187,9 @@ do
message="Proof verification failed for $proof [ ${batch_explorer_urls[@]} ]"
echo "$message"
send_pagerduty_alert "$message"
verified=0 # Some proofs failed, so we should not send the success message
break
elif echo "$verification" | grep -q verified; then
((verified++))
echo "Proof verification succeeded for $proof"
fi
done
Expand Down
2 changes: 1 addition & 1 deletion batcher/aligned-sdk/src/sdk.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,7 @@ pub fn get_payment_service_address(network: Network) -> ethers::types::H160 {

pub fn get_aligned_service_manager_address(network: Network) -> ethers::types::H160 {
match network {
Network::Devnet => H160::from_str("0x1613beB3B2C4f22Ee086B2b38C1476A3cE7f78E8").unwrap(),
Network::Devnet => H160::from_str("0x851356ae760d987E095750cCeb3bC6014560891C").unwrap(),
Network::Holesky => H160::from_str("0x58F280BeBE9B34c9939C3C39e0890C81f163B623").unwrap(),
Network::HoleskyStage => {
H160::from_str("0x9C5231FC88059C086Ea95712d105A2026048c39B").unwrap()
Expand Down
Loading