Upgrate bincode from 1.x to 2.0.0-rc.3#3899
Merged
Madoshakalaka merged 2 commits intomasterfrom Aug 21, 2025
Merged
Conversation
|
Visit the preview URL for this PR (updated for commit 1a00f3d): https://yew-rs-api--pr3899-upgrade-bincode-2-u86c5gt9.web.app (expires Thu, 28 Aug 2025 05:03:24 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
Benchmark - coreYew MasterPull Request |
Benchmark - SSRYew MasterDetails
Pull RequestDetails
|
Size ComparisonDetails
|
- Updated bincode dependency to 2.0.0-rc.3 in yew and yew-agent packages - Migrated from bincode::serialize/deserialize to bincode::serde::encode_to_vec/decode_from_slice - Updated test expectations for changed base64 encoding format - Used 2.0.0-rc.3 to maintain MSRV compatibility with Rust 1.78.0
2244563 to
2d8e509
Compare
d6355a8 to
38d416a
Compare
38d416a to
f268fef
Compare
f268fef to
307b346
Compare
307b346 to
1dd7b6f
Compare
1dd7b6f to
dc33495
Compare
dc33495 to
a685d62
Compare
a685d62 to
1a00f3d
Compare
Member
Author
|
force push mess was when I tried to fix the CI only ended up realizing it was a rustc nightly issue that only lasted for one day |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bincode 2 has big breaking changes, tried to use 2.0.1 but realized its MSRV is 1.85.0 and settled for 2.0.0-rc.3
I refered to bincode's migration guide
Migrated API calls:
Replaced
bincode::serializewithbincode::serde::encode_to_vecusingbincode::config::standard()Replaced
bincode::deserializewithbincode::serde::decode_from_sliceusingbincode::config::standard()