Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the AGENTS.md documentation to provide clearer build instructions and tips. It includes guidance on reusing existing build configurations, options to reduce build time, and common pitfalls during incremental builds. A suggestion was made to improve the clarity of the documentation regarding the initdb cmake target when used with test options.
| ./yb_build.sh release initdb | ||
| ``` | ||
| Pitfalls when doing incremental build: | ||
| - `initdb` cmake target in conjunction with `yb_build.sh` test options may not build `initdb`, so in that case, do them one by one. |
There was a problem hiding this comment.
The phrase "do them one by one" is a bit ambiguous. For better clarity, it would be helpful to be more explicit about the separate steps required. For example, you could suggest building initdb first and then running tests in a separate command.
| - `initdb` cmake target in conjunction with `yb_build.sh` test options may not build `initdb`, so in that case, do them one by one. | |
| - The `initdb` cmake target may not be built when specified in the same `yb_build.sh` command as test options. In this case, build `initdb` first in a separate command before running tests. |
Add coredb build instructions to src/AGENTS.md.
Note
Low Risk
Low risk because this PR only updates developer documentation and does not change any product or build scripts. The main risk is minor confusion if the suggested flags/targets become outdated.
Overview
Updates
src/AGENTS.mdwith expanded CoreDB build guidance: recommends reusing the existing build type viabuild/latest, documents commonyb_build.shflags to speed incremental builds, and lists incremental-build pitfalls.Adds refreshed example commands (including ASAN +
reinitdb) and links to the (potentially stale)build-and-testdocs page for more details.Written by Cursor Bugbot for commit af84f3d. This will update automatically on new commits. Configure here.