Skip to content

Conversation

TomNicholas
Copy link
Member

This PR is for testing support for @d-v-b's unmerged zarr data types refactor in zarr-developers/zarr-python#2874. Particularly we care about supporting big-endian data.

  • Closes #xxxx
  • Tests added
  • Tests passing
  • Full type hint coverage
  • Changes are documented in docs/releases.rst
  • New functions/methods are listed in api.rst
  • New functionality has documentation

@TomNicholas TomNicholas added zarr-python Relevant to zarr-python upstream zarr-specs Requires adoption of a new ZEP testing v3-migration test-upstream Run the upstream tests on this PR labels Apr 11, 2025
Co-authored-by: Ian Hunt-Isaak <[email protected]>
Co-authored-by: Ian Hunt-Isaak <[email protected]>
@TomNicholas
Copy link
Member Author

This is still using the wrong installed version 😞

We would appreciate you help with this @maxrjones

@maxrjones maxrjones added test-upstream Run the upstream tests on this PR and removed test-upstream Run the upstream tests on this PR labels Apr 11, 2025
@ianhi
Copy link

ianhi commented Apr 11, 2025

hooray!
image

@maxrjones
Copy link
Member

yeah the proper version is installed for the upstream tests (removing and adding test-upstream should trigger those) but looks like there'll be lots of failures and the tests are running slower - https://github.com/zarr-developers/VirtualiZarr/actions/runs/14409577052/job/40414132555?pr=545.

@maxrjones
Copy link
Member

might be worth trying the upstream tests out locally because it looks like the CI's hanging

pyproject.toml Outdated
'numcodecs @ git+https://github.com/zarr-developers/numcodecs',
'ujson @ git+https://github.com/ultrajson/ultrajson',
'zarr @ git+https://github.com/zarr-developers/zarr-python',
'zarr @ git+https://github.com/ianhi/zarr-python@feat/fixed-length-strings',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'zarr @ git+https://github.com/ianhi/zarr-python@feat/fixed-length-strings',
'zarr @ git+https://github.com/d-v-b/zarr-python@feat/fixed-length-strings',

@TomNicholas
Copy link
Member Author

Now that zarr-developers/zarr-python#2874 was merged upstream our normal upstream tests should be able to run against the updated zarr-python.

However I messed this PR up by merging from main (instead of develop) when trying to update it and instead of wasting time trying to untangle my git mess I just made another PR (#618) to replace this one. 🙃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test-upstream Run the upstream tests on this PR testing zarr-python Relevant to zarr-python upstream zarr-specs Requires adoption of a new ZEP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants