-
Notifications
You must be signed in to change notification settings - Fork 49
Zarr data types refactor compatibility #618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zarr data types refactor compatibility #618
Conversation
for more information, see https://pre-commit.ci
…zarr 3.1.0" This reverts commit 7a2e4f0.
@d-v-b what would be the preferred way to replace the usage of |
The functionality for serializing Nan / Inf / -Inf to a fill value now sits in stand-alone functions . The inverse functions are here. A few things to keep in mind:
|
@TomNicholas are you confident these are all changes we can handle internally? I'm asking since 3.1.0 will hopefully come out tomorrow - zarr-developers/zarr-python#3219. Would you like any help wrapping this up? |
I think this shouldn't present a blocker but I would definitely appreciate help getting it over the finish line! |
FYI I think this is good now - the failures should all relate to #673 |
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thank you! The final changes are surprisingly small. I can't approve my own PR, but I think we should add a release note for this one and merge.
This doesn't touch anything that's been released (😞) so IMO we don't need a release note. |
Supercedes #545 now that zarr-developers/zarr-python#2874 has been merged upstream.
The upstream changes are already being tested (and unsurprisingly causing some issues - see also #617) in our upstream dev CI tests. But here we will x-fail stuff, start trying to fix things, and bump required dependencies.
docs/releases.rst
api.rst
FYI @d-v-b