fix(consolidated metadata): skip .zmetadata key in members search #2356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I don't see a problem description or bug report in the linked issue (maybe i missed it). Is the problem this PR solves basically that |
Member
Author
|
@d-v-b - yes, exactly. I've added a description to this point. |
d-v-b
approved these changes
Oct 13, 2024
Contributor
d-v-b
left a comment
d-v-b
left a comment
There was a problem hiding this comment.
looks good, thanks for this
6 tasks
TomAugspurger
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small patch on the back of #1161.
Without this change, the logic in
memberswas identifying.zmetadataas a valid key in the store and looking for its children (e.g.foo/.zmetadata/.zarray). The result was a bunch of noisy warnings about unrecognized keys.TODO: