-
-
Notifications
You must be signed in to change notification settings - Fork 357
Open zip store from path with zip suffix #2856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
I did not add anything in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just one minor comment, but I think worth fixing 👍
Hi @dstansby , I'm not sure, but it seems your suggested change that worked in march now breaks the tests. Did some assumptions change about |
ZipStore
if the path has a.zip
suffix.Fixes #2831
docs/user-guide/*.rst
changes/
The added test is not as elegant as the other from the suite. Is there a way to get an existing zipped zarr dataset within the test suite ? Should I create another fixture instead of writing my own zarr in the test ?