Skip to content

remove insertion of vlen-string codec for v2 metadata creation #3100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 28, 2025
Merged

remove insertion of vlen-string codec for v2 metadata creation #3100

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e2e1f9d
remove insertion of vlen-string codec for v2 metadata creation
d-v-b May 27, 2025
33cccc1
changelog
d-v-b May 27, 2025
0597c32
Update changes/3100.bugfix.rst
d-v-b May 27, 2025
c2c2f40
Update changes/3100.bugfix.rst
d-v-b May 27, 2025
97fa0b5
Merge branch 'main' of https://github.com/zarr-developers/zarr-python…
d-v-b May 28, 2025
7908f54
add dtype strings to test_v2_chunk_encoding
d-v-b May 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions changes/3100.bugfix.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Zarr V2: allow fixed-length string arrays to be created without automatically inserting a
``Vlen-UT8`` codec in the array of filters. Fixed-length string arrays do not need this codec. This
change fixes regressions against Zarr Python 2.18.
8 changes: 0 additions & 8 deletions src/zarr/core/array.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -768,14 +768,6 @@ def _create_metadata_v2(

dtype = parse_dtype(dtype, zarr_format=2)

# inject VLenUTF8 for str dtype if not already present
if np.issubdtype(dtype, np.str_):
filters = filters or []
from numcodecs.vlen import VLenUTF8

if not any(isinstance(x, VLenUTF8) or x["id"] == "vlen-utf8" for x in filters):
filters = list(filters) + [VLenUTF8()]

return ArrayV2Metadata(
shape=shape,
dtype=np.dtype(dtype),
Expand Down