-
-
Notifications
You must be signed in to change notification settings - Fork 368
Refactor make_store_path for clarity #3308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor make_store_path for clarity #3308
Conversation
|
nice! the ultimate refactor would be removing the |
6ecd146 to
2da031f
Compare
c16beef to
92f4e89
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3308 +/- ##
==========================================
- Coverage 60.72% 60.69% -0.03%
==========================================
Files 78 78
Lines 9408 9401 -7
==========================================
- Hits 5713 5706 -7
Misses 3695 3695
🚀 New features to boost your workflow:
|
92f4e89 to
769785f
Compare
d-v-b
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. We should absolutely consider doing away with StorePath entirely, but that's a later PR
Co-authored-by: David Stansby <[email protected]>
This refactors
make_store_pathto make the code easier to read by:TypeErrorfor unusedstorage_optionsto the top of the funcitonThere should not be any behaviour changes here.