Skip to content

Ensure absolute paths work with consolidate metadata #3428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 3, 2025
Merged

Ensure absolute paths work with consolidate metadata #3428

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7550061
Ensure absolute paths work with consolidate metadata
shoyer Sep 2, 2025
6dd2b21
bug fix note
shoyer Sep 2, 2025
baec8c1
ruff format
shoyer Sep 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/zarr/core/group.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -735,7 +735,7 @@ def _getitem_consolidated(
assert self.metadata.consolidated_metadata is not None

# we support nested getitems like group/subgroup/array
indexers = key.split("/")
indexers = normalize_path(key).split("/")
indexers.reverse()
metadata: ArrayV2Metadata | ArrayV3Metadata | GroupMetadata = self.metadata

Expand Down
16 changes: 16 additions & 0 deletions tests/test_metadata/test_consolidated.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -692,6 +692,22 @@ async def test_use_consolidated_for_children_members(
expected = ["b", "b/c"]
assert result == expected

async def test_absolute_path_for_subgroup(
self, memory_store: zarr.storage.MemoryStore
) -> None:
root = await zarr.api.asynchronous.create_group(store=memory_store)
await root.create_group("a/b")
with pytest.warns(
ZarrUserWarning,
match="Consolidated metadata is currently not part in the Zarr format 3 specification.",
):
await zarr.api.asynchronous.consolidate_metadata(memory_store)

group = await zarr.api.asynchronous.open_group(store=memory_store)
subgroup = await group.getitem("/a")
members = [x async for x in subgroup.keys()] # type: ignore[union-attr]
assert members == ["b"]


@pytest.mark.parametrize("fill_value", [np.nan, np.inf, -np.inf])
async def test_consolidated_metadata_encodes_special_chars(
Expand Down
Loading