Ensure absolute paths work with consolidate metadata #3428
Merged
+17
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs release notes
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3428 +/- ##
=======================================
Coverage 94.92% 94.92%
=======================================
Files 79 79
Lines 9503 9503
=======================================
Hits 9021 9021
Misses 482 482
🚀 New features to boost your workflow:
|
d-v-b
requested changes
Sep 2, 2025
Contributor
d-v-b
left a comment
d-v-b
left a comment
There was a problem hiding this comment.
thanks! we just need some release notes and then this is good to go.
github-actions
bot
removed
the
needs release notes
shoyer
added a commit
to shoyer/xarray
that referenced
this pull request
Sep 2, 2025
Writing to zarr with `mode='r+'` was broken by pydata#10625, due to a Zarr bug (zarr-developers/zarr-python#3428). This add a work-around that works on older versions of Zarr. The PR that introduced this bug has not yet appeared in an xarray release, so there's no need for a release note.
1 task
Contributor
Author
|
Should be good to go now |
d-v-b
approved these changes
Sep 3, 2025
Contributor
|
thanks @shoyer! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures syntax like
root['/subgroup']works equivalently toroot['subgroup']when using consolidated metadata.TODO:
changes/