-
Notifications
You must be signed in to change notification settings - Fork 3
feat: initialise from ArrayMetadata
and store
#104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilan-gold
reviewed
Jul 15, 2025
ilan-gold
reviewed
Jul 15, 2025
Co-authored-by: Ilan Gold <[email protected]>
ilan-gold
approved these changes
Jul 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from_array_metadata_and_store
toCodecPipeline
zarr-developers/zarr-python#3233 which looks like it will release withzarr-python
3.1obstore
support).This simplifies a lot, removes the
StoreManager
and lets us properly support a broader range of arrays where codec behaviour is dependent on non-codec metadata (e.g.data_type
,order
).I added a warning that indicates to a user why an array is not supported by
zarrs
when constructing aZarrsCodecPipeline
. This catches a few things and reveals some holes inzarrs
support for Zarr V2 data which can be supported eventually. Features that aren't supported byzarrs-python
, like variable sized data types, still just silently fallback at runtime.