settings_ui: Fix hover popover delay setting's json_path#53359
Merged
SomeoneToIgnore merged 1 commit intozed-industries:mainfrom Apr 8, 2026
Merged
settings_ui: Fix hover popover delay setting's json_path#53359SomeoneToIgnore merged 1 commit intozed-industries:mainfrom
SomeoneToIgnore merged 1 commit intozed-industries:mainfrom
Conversation
|
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: daydalek.
|
The "Hover Popover → Delay" setting item had its json_path set to "hover_popover_enabled" (copy-paste error from the item above it), introduced in zed-industries#40739. This caused: - "Copy Link" generating a wrong zed://settings/hover_popover_enabled URL - #hover_popover_delay filter returning no results in settings search - navigate_to_setting("hover_popover_delay") silently failing - Telemetry reporting delay changes as hover_popover_enabled The pick/write closures were always correct, so the setting itself functioned normally. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
f53a201 to
4dddb55
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Hover Popover → Delay" setting item had its json_path set to "hover_popover_enabled" (copy-paste error from the item above it), introduced in #40739. This caused:
The pick/write closures were always correct, so the setting itself functioned normally.
after the fix, filter works correctly
and the copy link button return the correct result

Release Notes: