Skip to content

settings_ui: Fix hover popover delay setting's json_path#53359

Merged
SomeoneToIgnore merged 1 commit intozed-industries:mainfrom
daydalek:fix-hover-delay-json-path
Apr 8, 2026
Merged

settings_ui: Fix hover popover delay setting's json_path#53359
SomeoneToIgnore merged 1 commit intozed-industries:mainfrom
daydalek:fix-hover-delay-json-path

Conversation

@daydalek
Copy link
Copy Markdown
Contributor

@daydalek daydalek commented Apr 8, 2026

The "Hover Popover → Delay" setting item had its json_path set to "hover_popover_enabled" (copy-paste error from the item above it), introduced in #40739. This caused:

  • "Copy Link" generating a wrong zed://settings/hover_popover_enabled URL
  • #hover_popover_delay filter returning no results in settings search
  • Telemetry reporting delay changes as hover_popover_enabled

The pick/write closures were always correct, so the setting itself functioned normally.

after the fix, filter works correctly

image

and the copy link button return the correct result
image

Release Notes:

  • Fixed an issue where "Hover Popover Delay" setting could not be searched or linked correctly in the settings UI.

Copilot AI review requested due to automatic review settings April 8, 2026 03:41
@cla-bot
Copy link
Copy Markdown

cla-bot bot commented Apr 8, 2026

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: daydalek.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@zed-codeowner-coordinator zed-codeowner-coordinator bot requested review from a team, MrSubidubi and osiewicz and removed request for a team and Copilot April 8, 2026 03:41
The "Hover Popover → Delay" setting item had its json_path set to
"hover_popover_enabled" (copy-paste error from the item above it),
introduced in zed-industries#40739. This caused:

- "Copy Link" generating a wrong zed://settings/hover_popover_enabled URL
- #hover_popover_delay filter returning no results in settings search
- navigate_to_setting("hover_popover_delay") silently failing
- Telemetry reporting delay changes as hover_popover_enabled

The pick/write closures were always correct, so the setting itself
functioned normally.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@daydalek daydalek force-pushed the fix-hover-delay-json-path branch from f53a201 to 4dddb55 Compare April 8, 2026 03:44
@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Apr 8, 2026
Copy link
Copy Markdown
Contributor

@SomeoneToIgnore SomeoneToIgnore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@SomeoneToIgnore SomeoneToIgnore self-assigned this Apr 8, 2026
@SomeoneToIgnore SomeoneToIgnore enabled auto-merge (squash) April 8, 2026 06:45
@SomeoneToIgnore SomeoneToIgnore merged commit 81733d4 into zed-industries:main Apr 8, 2026
39 checks passed
@daydalek daydalek deleted the fix-hover-delay-json-path branch April 8, 2026 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants