Skip to content

Conversation

RobinKastberg
Copy link

@RobinKastberg RobinKastberg commented Jan 20, 2025

Add the cmsis_5 build system to cmsis_6
Someone more knowledgable then me needs to check this.

PS: IAR has a CRITICAL bug in CMSIS 5.9.0 so to be able to support zephyr (coming shortly) we really really need CMSIS_6 or backport the fix into CMSIS 5.9.0.

Zephyr PR: zephyrproject-rtos/zephyr#84330

@wearyzen
Copy link
Collaborator

Hi @RobinKastberg, could you please add more details in the commit message like what the change is and why is it needed? Also, in the PR description, please add a link to the Zephyr PR that validates these changes in the Zephyr CI infrastructure. Please have a look at https://docs.zephyrproject.org/latest/develop/modules.html#process-for-submitting-changes-to-existing-modules for more details.

@RobinKastberg RobinKastberg force-pushed the cmsis_6-zephyr-integration branch from e82c5b3 to 23c5406 Compare January 21, 2025 15:21
ARM has deprecated 5.9.0 and we will need to start using CMSIS_6
to get upstream features and continue supporting tf-m.
This commit will integrate it just like CMSIS_5.

Signed-off-by: Robin Kastberg <[email protected]>
@RobinKastberg
Copy link
Author

Hi @RobinKastberg, could you please add more details in the commit message like what the change is and why is it needed? Also, in the PR description, please add a link to the Zephyr PR that validates these changes in the Zephyr CI infrastructure. Please have a look at https://docs.zephyrproject.org/latest/develop/modules.html#process-for-submitting-changes-to-existing-modules for more details.

Thanks! I hadn't read that part of the manual. Here is the zephyr PR:
zephyrproject-rtos/zephyr#84330

@RobinKastberg
Copy link
Author

It looks like we are missing zephyrproject-rtos/cmsis@54eaf19

@wearyzen
Copy link
Collaborator

wearyzen commented May 1, 2025

Using this PR for switching TF-M and Cortex-M to CMSIS_6, Zephyr PR that uses this is : zephyrproject-rtos/zephyr#89370

@wearyzen
Copy link
Collaborator

wearyzen commented May 7, 2025

@RobinKastberg I was not able to push a change to your PR so created another one here. I'll follow up progress on that for convenience.

@wearyzen
Copy link
Collaborator

wearyzen commented May 8, 2025

These changes are merged via another PR so closing this.

@wearyzen wearyzen closed this May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants