add gd32e103xx pin config #12

feilongfl · 2021-11-22T21:18:01Z

add pinconfig yaml for gd32e103xx
gen files by gd32pinctrl.py script.

I noticed that the serial name of Gigadevice has changed unusually a few months ago.
They removed the CAN-FD module of the gd32e103 chip,
and the old gd32e103 with CAN-FD was renamed as gd32c103.
This PR for the new gd32e103 only.

pinconfigs/gd32e103xx.yml

include/dt-bindings/pinctrl/gd32e103t(b-8)xx-pinctrl.h

nandojve

Hi @feilongfl ,
Thank you for your PR. Please, link this with your board at Zephyr main repo.
We need build a board there using this newer changes to accept PR.

feilongfl · 2021-12-01T10:13:29Z

Hi @feilongfl , Thank you for your PR. Please, link this with your board at Zephyr main repo. We need build a board there using this newer changes to accept PR.

Sorry for waste your guys time to review this in-process PR.
When I use this one to compile soc, I found I miss something must be done here. I'll push this PR when I fix error.

nandojve · 2021-12-01T15:40:15Z

Hi @feilongfl , Thank you for your PR. Please, link this with your board at Zephyr main repo. We need build a board there using this newer changes to accept PR.

Sorry for waste your guys time to review this in-process PR. When I use this one to compile soc, I found I miss something must be done here. I'll push this PR when I fix error.

Don't worry about it @feilongfl everyone is learning here.
Please, update your PRs at Zephyr main repo with missing info to be possible move forward.

You can look zephyrproject-rtos/zephyr#40283 and use it as guidance.

Tips:

No need to add wip, when you open PR, simple select Draft when you create it. This tell us that PR is still in progress. If you need assistance, you can ask and someone will, eventually, help you.
After people let you reviews, you can ask to them look again by clicking at circle with arrows, left side people names. That will inform reviewers that you already update everything or need that person check again PR.

feilongfl · 2021-12-05T03:14:21Z

Hi @nandojve @gmarull
I've update this PR, and tested sample/hello_world with zephyrproject-rtos/zephyr#36833

resolved problem which raised by @gmarull
add gd32e10x_libopt.h from GD32E10x_Firmware_Library_V1.2.0/Examples/GPIO/Running_led/gd32e10x_libopt.h
Some patches in HAL
- force use external 8M oscillator
  I think we will use value from devicetree later, so there only fix for gd32e103v_eval board.
- remove nvic config
  I think nvic is config by zephyr, don't need to config here.
- enable MPU flag.
  I found that all of header file in hal_gigadevice module is include only when MPU is enable.
  When the MPU is not available, I don't know how to include the files.
  so I think temporary enable __MPU_PRESENT marco is a good idea.

pinconfigs/gd32e103xx.yml

include/dt-bindings/pinctrl/gd32e103c(b-8)xx-pinctrl.h

include/dt-bindings/pinctrl/gd32e103xx-afio.h

gd32e10x/cmsis/gd/gd32e10x/include/gd32e10x.h

gd32e10x/cmsis/gd/gd32e10x/source/system_gd32e10x.c

gd32e10x/cmsis/gd/gd32e10x/include/gd32e10x.h

nandojve

Hi @feilongfl ,

Nice work!

I think you only need to drop all CAN related at gd32e103.

include/dt-bindings/pinctrl/gd32e103xx-afio.h

gd32e10x/cmsis/gd/gd32e10x/source/system_gd32e10x.c

gmarull · 2021-12-10T09:37:01Z

gd32e10x/cmsis/gd/gd32e10x/include/gd32e10x.h

 #if !defined  HXTAL_VALUE
-  #ifdef GD32E103V_EVAL
+  #ifdef CONFIG_BOARD_GD32E103V_EVAL
  #define HXTAL_VALUE    ((uint32_t)8000000) /*!< value of the external oscillator in Hz */
  #define HXTAL_VALUE_8M  HXTAL_VALUE
-  #elif defined(GD32E103R_START)
+  #elif defined(CONFIG_BOARD_GD32E103R_START)


HAL headers can't depend on Kconfig variables. Instead, Zephyr build system should insert the HXTAL_VALUE based on a Kconfig or DT value. See zephyrproject-rtos/zephyr@a939085

I tried to use HXTAL_VALUE, but I'm a bit unsure if it's the same as your idea.

nandojve

Drop hal:gd32e10x: temporary enable MPU flag commit. You need remove MPU at dts and soc definition.
Drop standard_peripheral/include/gd32e10x_fmc.c file.

feilongfl · 2021-12-11T02:05:11Z

Drop hal:gd32e10x: temporary enable MPU flag commit. You need remove MPU at dts and soc definition.

If I Drop this commit, I'll get a compile error that header file in hal_gigadevice is not included.

I try to analyse why these file not included, I write them here.
#12 (comment)

Currently I have found no way to solve this problem other than turning on MPU.

nandojve · 2021-12-11T02:13:46Z

Please, check zephyrproject-rtos/zephyr#36833 (review) and let me know result.

feilongfl · 2021-12-11T02:35:50Z

Please, check zephyrproject-rtos/zephyr#36833 (review) and let me know result.

You're right, I forget that I can also modify the driver code.

gmarull · 2021-12-12T16:32:51Z

gd32e10x/cmsis/gd/gd32e10x/include/gd32e10x.h

+    /* get external oscillator from KCONFIG */
+    #define HXTAL_VALUE CONFIG_GD32_HXTAL_VALUE
+    #if HXTAL_VALUE == 8000000
+      #define HXTAL_VALUE_8M  HXTAL_VALUE
+    #elif HXTAL_VALUE == 25000000
+      #define HXTAL_VALUE_25M  HXTAL_VALUE
+    #else
+      #error "GD32E10X lib only support 8M and 25M oscillator (HXTAL)"
+    #endif


There's no need to do that, just drop this commit and do the same as zephyrproject-rtos/zephyr@a939085 (cherry-pick it in your PR while it's not merged, even though it's now approved so it'll go in soon)

Oh,I see HXTAL_VALUE was defined in cmake script, I'll remove it.
Because of code in https://github.com/zephyrproject-rtos/hal_gigadevice/blob/main/gd32e10x/cmsis/gd/gd32e10x/source/system_gd32e10x.c#L745-L751 ,
I need HXTAL_VALUE_8M or HXTAL_VALUE_25M marco to make clock config success.

gd32e10x/standard_peripheral/include/gd32e10x_fmc.c

Add pin configurations for the GD32E103XX SoCs. Signed-off-by: YuLong Yao <[email protected]>

Add remap definitions for GD32E103XX SoCs. Signed-off-by: YuLong Yao <[email protected]>

Files autogenerated using the gd32pinctrl.py script. Signed-off-by: YuLong Yao <[email protected]>

file from `GD32E10x_Demo_Suites_V1.2.0` Signed-off-by: YuLong Yao <[email protected]>

drop `nvic_vector_table_set`call in `SystemInit` function. Signed-off-by: YuLong Yao <[email protected]>

drop standard_peripheral/include/gd32e10x_fmc.c

add HXTAL_VALUE_8M and HXTAL_VALUE_25M marco by HXTAL_VALUE. Signed-off-by: YuLong Yao <[email protected]>

feilongfl changed the title ~~add gd32e103xx pin config~~ [wip]add gd32e103xx pin config Nov 24, 2021

gmarull suggested changes Nov 30, 2021

View reviewed changes

pinconfigs/gd32e103xx.yml Outdated Show resolved Hide resolved

pinconfigs/gd32e103xx.yml Show resolved Hide resolved

gmarull reviewed Nov 30, 2021

View reviewed changes

include/dt-bindings/pinctrl/gd32e103t(b-8)xx-pinctrl.h Show resolved Hide resolved

nandojve suggested changes Nov 30, 2021

View reviewed changes

nandojve added the DNM Do Not Merge label Nov 30, 2021

feilongfl force-pushed the main branch 2 times, most recently from 8e80fac to 4c671fc Compare December 5, 2021 02:37

feilongfl mentioned this pull request Dec 5, 2021

boards: arm: Add gd32e103v_eval board zephyrproject-rtos/zephyr#36833

Merged

feilongfl changed the title ~~[wip]add gd32e103xx pin config~~ add gd32e103xx pin config Dec 5, 2021

gmarull suggested changes Dec 9, 2021

View reviewed changes

feilongfl force-pushed the main branch from 4c671fc to 2f409f0 Compare December 9, 2021 22:32

nandojve approved these changes Dec 9, 2021

View reviewed changes

include/dt-bindings/pinctrl/gd32e103xx-afio.h Outdated Show resolved Hide resolved

include/dt-bindings/pinctrl/gd32e103xx-afio.h Outdated Show resolved Hide resolved

feilongfl force-pushed the main branch from 2f409f0 to e13d151 Compare December 9, 2021 23:13

gmarull suggested changes Dec 10, 2021

View reviewed changes

feilongfl force-pushed the main branch 2 times, most recently from 8d07746 to 41d9fbd Compare December 11, 2021 00:09

nandojve suggested changes Dec 11, 2021

View reviewed changes

feilongfl force-pushed the main branch from 41d9fbd to d348e5c Compare December 11, 2021 02:31

gmarull suggested changes Dec 12, 2021

View reviewed changes

nandojve suggested changes Dec 12, 2021

View reviewed changes

gd32e10x/standard_peripheral/include/gd32e10x_fmc.c Show resolved Hide resolved

feilongfl force-pushed the main branch 3 times, most recently from 4167d62 to d36cb81 Compare December 15, 2021 10:54

pinconfigs: add gd32e103xx pin configurations

70bb94b

Add pin configurations for the GD32E103XX SoCs. Signed-off-by: YuLong Yao <[email protected]>

feilongfl added 6 commits February 21, 2022 05:35

dt-bindings: add gd32e103xx afio definitions

0ef47bc

Add remap definitions for GD32E103XX SoCs. Signed-off-by: YuLong Yao <[email protected]>

dt-bindings: add pinctrl gd32e103xx generated headers

709136b

Files autogenerated using the gd32pinctrl.py script. Signed-off-by: YuLong Yao <[email protected]>

hal:gd32e10x:add libopt.h from gigadevice demo.

68fb424

file from `GD32E10x_Demo_Suites_V1.2.0` Signed-off-by: YuLong Yao <[email protected]>

hal:gd32e10x: drop nvic settring in SystemInit

d3919f5

drop `nvic_vector_table_set`call in `SystemInit` function. Signed-off-by: YuLong Yao <[email protected]>

hal:gd32e10x: drop file in wrong location.

3434330

drop standard_peripheral/include/gd32e10x_fmc.c

hal: gd32e10x: set marco based on HXTAL_VALUE.

16c8a53

add HXTAL_VALUE_8M and HXTAL_VALUE_25M marco by HXTAL_VALUE. Signed-off-by: YuLong Yao <[email protected]>

feilongfl force-pushed the main branch from d36cb81 to 16c8a53 Compare February 20, 2022 21:36

gmarull approved these changes Feb 21, 2022

View reviewed changes

gmarull requested a review from nandojve February 21, 2022 08:55

nandojve merged commit cc85acb into zephyrproject-rtos:main Feb 21, 2022

add gd32e103xx pin config #12

add gd32e103xx pin config #12

Uh oh!

Conversation

feilongfl commented Nov 22, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nandojve left a comment

Choose a reason for hiding this comment

Uh oh!

feilongfl commented Dec 1, 2021

Uh oh!

nandojve commented Dec 1, 2021

Uh oh!

feilongfl commented Dec 5, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nandojve left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gmarull Dec 10, 2021

Choose a reason for hiding this comment

Uh oh!

feilongfl Dec 10, 2021

Choose a reason for hiding this comment

Uh oh!

nandojve left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

feilongfl commented Dec 11, 2021

Uh oh!

nandojve commented Dec 11, 2021

Uh oh!

feilongfl commented Dec 11, 2021

Uh oh!

gmarull Dec 12, 2021

Choose a reason for hiding this comment

Uh oh!

feilongfl Dec 12, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

nandojve left a comment •

edited

Loading