lib: stm32wba: 802.15.4 driver integration #311

vtardy-st · 2025-09-03T08:25:49Z

It's a draft version to retrieve a first review

Add 802.15.4 driver integration
In the lib\stm32wba, 'BLE_TransparentMode' folder has been renamed 'ble'.
Add CMakeLists.txt file in /ble folder
Add IEEE802154 folder

zephyr/module.yml

erwango

For clarity, please split your changes in several commits:

Initial commit(s) that make(s) required modifications prior the introduction of the new library (files moving and sp on)
Dedicated commit that only introduces new lib + required CMake changes

Last, I don't see changes to the library update scripts. I really think this should be added to help maintainance

What is the plan for library update ?

lib/stm32wba/Utilities/trace/adv_trace/stm32_adv_trace.h

lib/stm32wba/IEEE802154/System/Config/Debug_GPIO/debug_config.h

vtardy-st · 2025-09-15T08:36:36Z

Changes included in this PR have been splitted in 2 commits :

first commit related to ble folder renaming and change/add CMakeList in prevision of IEEE802154 integration
second commit related to IEEE802154 files + libs

erwango

In the first commit, a lot of files are moved in but not updated in README or update script file. These files should be updated. This is mandatory for further maintenance.

lib/stm32wba/STM32_WPAN/CMakeLists.txt

lib/stm32wba/STM32_WPAN/link_layer/CMakeLists.txt

lib/stm32wba/ble/CMakeLists.txt

lib/stm32wba/STM32_WPAN/link_layer/ll_sys/CMakeLists.txt

erwango

Sorry for the review split in multiple comments, this will be the last one.

I'm not opposed to reshuffling the CMakeLists.txt, and this probably welcome given the introduction of a new library and the fact that some components are shared between the 2.
Though, I think current proposal goes to far in this direction and makes things quite difficult to follow.
I'd propose to limit to 3/4 files instead of the 6 proposed currently (in my view, lesser is better, but I may miss technical constraints)

lib/stm32wba/STM32_WPAN/link_layer/ll_sys/CMakeLists.txt

lib/stm32wba/CMakeLists.txt

lib/stm32wba/STM32_WPAN/link_layer/ll_sys/CMakeLists.txt

AhmedFaizyST · 2025-09-16T07:06:33Z

lib/stm32wba/IEEE802154/CMakeLists.txt

+
+if(CONFIG_IEEE802154_STM32WBA)
+	zephyr_include_directories(Inc)
+	zephyr_include_directories(Core/Inc/802154)


We need to exclude this directory if the build is for Zigbee because ZB has its own app_conf.h file

A change has been implemented to include this directory only if CONFIG_NET_L2_CUSTOM_IEEE802154_STM32WBA is not defined

lib/stm32wba/CMakeLists.txt

lib/CMakeLists.txt

lib/stm32wba/STM32_WPAN/CMakeLists.txt

zephyr/module.yml

etienne-lms

Minor nitpicking comments.

etienne-lms · 2025-09-17T08:55:30Z

lib/stm32wba/CMakeLists.txt

    OR CONFIG_BT_TRANSMIT_POWER_CONTROL
    OR CONFIG_BT_SUBRATING
    OR CONFIG_BT_CTLR_ADV_PERIODIC_ADI_SUPPORT
    OR CONFIG_BT_EXT_ADV_CODING_SELECTION)


For consistency, the 10 lines above should be indented by 1 more space char.

identation has been reviewed

etienne-lms · 2025-09-17T08:57:20Z

lib/stm32wba/CMakeLists.txt

+      set(LL_LIB "WBA6_LinkLayer_Thread_lib.a")
+    else()
+      message(STATUS "WBA6_LinkLayer15_4.a lib selected")
+	    set(LL_LIB "WBA6_LinkLayer15_4.a")


Indentation:

Suggested change

set(LL_LIB "WBA6_LinkLayer15_4.a")

set(LL_LIB "WBA6_LinkLayer15_4.a")

indentation change done

etienne-lms · 2025-09-17T09:01:11Z

lib/stm32wba/README.rst


 Purpose:
-   This library is used on STM32WBA series to port  BLE controller library in
+   This library is used on STM32WBA series to port BLE and IEEE802154 controller library in


Replace library with libraries ?

etienne-lms · 2025-09-17T09:02:38Z

lib/stm32wba/STM32_WPAN/ieee802154/stm32wba_802154_callbacks.h

+ */
+
+#ifndef STM32WBA_802154_CALLOUTS_H_
+#define STM32WBA_802154_CALLOUTS_H_


As per the header file names, it would be better the header guard macros are named STM32_802154_CALLBACKS_H_.

header guard macro has been modified

etienne-lms

LGTM AFAICT.

etienne-lms · 2025-09-22T05:14:39Z

lib/stm32wba/STM32_WPAN/ieee802154/stm32wba_802154_callbacks.h

+	 *
+	 * @retval none
+	 */
+	void (*stm32wba_802154_ral_cbk_ed_scan_done)(int8_t rssiResult);


Non-blokcing issue but for information:
These fields belong to struct stm32wba_802154_ral_cbk_dispatch_tbl that is already explicitly prefixed stm32wba_802154_ral_cbk_ so there is no strong need for the prefix also in the field names.

erwango

Getting close..

lib/stm32wba/STM32_WPAN/CMakeLists.txt

README.rst

lib/stm32wba/CMakeLists.txt

README.rst

rename ble folder and add/change CMakeList Signed-off-by: Vincent Tardy <[email protected]>

Add 802.15.4 driver integration Signed-off-by: Vincent Tardy <[email protected]>

erwango · 2025-09-23T07:42:57Z

lib/stm32wba/STM32_WPAN/CMakeLists.txt

-if (CONFIG_BT_STM32WBA)
-zephyr_include_directories(ble/stack/include)
-zephyr_include_directories(ble/stack/include/auto)
-zephyr_include_directories(link_layer/ll_cmd_lib/config/ble_full)


Ideally indentation should have been fixed in initial commit, but I' won't block for this at this point.

erwango

Looks good to me, thanks!

etienne-lms

LGTM AFAICT.

github-actions bot mentioned this pull request Sep 3, 2025

stm32wbax 802154 driver support zephyrproject-rtos/zephyr#95376

Merged

erwango reviewed Sep 3, 2025

View reviewed changes

zephyr/module.yml Outdated Show resolved Hide resolved

vtardy-st force-pushed the stm32wbax_802154_driver_support branch 4 times, most recently from 539e08e to 6631ae3 Compare September 9, 2025 13:46

vtardy-st marked this pull request as ready for review September 10, 2025 08:07

vtardy-st force-pushed the stm32wbax_802154_driver_support branch from 6631ae3 to ebe3cdc Compare September 12, 2025 08:08

erwango requested changes Sep 12, 2025

View reviewed changes

lib/stm32wba/Utilities/trace/adv_trace/stm32_adv_trace.h Show resolved Hide resolved

lib/stm32wba/IEEE802154/System/Config/Debug_GPIO/debug_config.h Show resolved Hide resolved

vtardy-st force-pushed the stm32wbax_802154_driver_support branch from ebe3cdc to 89b8400 Compare September 15, 2025 08:34

erwango requested changes Sep 15, 2025

View reviewed changes

lib/stm32wba/STM32_WPAN/CMakeLists.txt Outdated Show resolved Hide resolved

lib/stm32wba/STM32_WPAN/link_layer/CMakeLists.txt Outdated Show resolved Hide resolved

erwango requested changes Sep 15, 2025

View reviewed changes

lib/stm32wba/ble/CMakeLists.txt Outdated Show resolved Hide resolved

lib/stm32wba/STM32_WPAN/link_layer/ll_sys/CMakeLists.txt Outdated Show resolved Hide resolved

lib/stm32wba/STM32_WPAN/link_layer/ll_sys/CMakeLists.txt Outdated Show resolved Hide resolved

erwango requested changes Sep 15, 2025

View reviewed changes

lib/stm32wba/STM32_WPAN/link_layer/ll_sys/CMakeLists.txt Outdated Show resolved Hide resolved

lib/stm32wba/CMakeLists.txt Outdated Show resolved Hide resolved

lib/stm32wba/STM32_WPAN/link_layer/ll_sys/CMakeLists.txt Outdated Show resolved Hide resolved

AhmedFaizyST suggested changes Sep 16, 2025

View reviewed changes

vtardy-st force-pushed the stm32wbax_802154_driver_support branch from 89b8400 to 8fc6994 Compare September 16, 2025 10:30

erwango requested changes Sep 16, 2025

View reviewed changes

vtardy-st force-pushed the stm32wbax_802154_driver_support branch from 8fc6994 to 8704abd Compare September 16, 2025 13:26

etienne-lms reviewed Sep 17, 2025

View reviewed changes

vtardy-st force-pushed the stm32wbax_802154_driver_support branch from 8704abd to f24aa8b Compare September 19, 2025 13:52

vtardy-st requested review from erwango and etienne-lms September 22, 2025 07:47

etienne-lms approved these changes Sep 22, 2025

View reviewed changes

AhmedFaizyST approved these changes Sep 22, 2025

View reviewed changes

vtardy-st force-pushed the stm32wbax_802154_driver_support branch from f24aa8b to 9b4878b Compare September 22, 2025 13:30

erwango requested changes Sep 22, 2025

View reviewed changes

lib/stm32wba/STM32_WPAN/CMakeLists.txt Outdated Show resolved Hide resolved

README.rst Show resolved Hide resolved

lib/stm32wba/CMakeLists.txt Outdated Show resolved Hide resolved

README.rst Outdated Show resolved Hide resolved

vtardy-st added 2 commits September 22, 2025 17:19

lib: stm32wba: Update ble folder architecture on STM32WBA

ec633de

rename ble folder and add/change CMakeList Signed-off-by: Vincent Tardy <[email protected]>

lib: stm32wba: 802.15.4 driver integration

04222c0

Add 802.15.4 driver integration Signed-off-by: Vincent Tardy <[email protected]>

vtardy-st force-pushed the stm32wbax_802154_driver_support branch from 9b4878b to 04222c0 Compare September 22, 2025 15:25

vtardy-st requested a review from erwango September 22, 2025 15:26

erwango reviewed Sep 23, 2025

View reviewed changes

erwango approved these changes Sep 23, 2025

View reviewed changes

etienne-lms approved these changes Sep 23, 2025

View reviewed changes

erwango merged commit dc7c254 into zephyrproject-rtos:main Sep 23, 2025
2 checks passed

	set(LL_LIB "WBA6_LinkLayer15_4.a")
	set(LL_LIB "WBA6_LinkLayer15_4.a")

lib: stm32wba: 802.15.4 driver integration #311

lib: stm32wba: 802.15.4 driver integration #311

Uh oh!

Conversation

vtardy-st commented Sep 3, 2025

Uh oh!

Uh oh!

erwango left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

vtardy-st commented Sep 15, 2025

Uh oh!

erwango left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

erwango left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

etienne-lms left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

etienne-lms left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

erwango left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

erwango Sep 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

erwango left a comment

Choose a reason for hiding this comment

Uh oh!

etienne-lms left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

erwango Sep 23, 2025 •

edited

Loading