Skip to content

Conversation

@lsd-he360
Copy link

@lsd-he360 lsd-he360 commented Nov 5, 2025

Adds a seperate pinctrl file for gx51x family. This file shares many configurations with the g1x0x/g3x0x but supports additonal pins and peripherals.

The commit in this PR is cherry picked from TexasInstruments/msp-hal_ti@e3968fe

Adds a seperate pinctrl file for gx51x family. This file
shares many configurations with the g1x0x/g3x0x but supports
additonal pins and peripherals.

Signed-off-by: Dylan Philpot <[email protected]>
@lsd-he360
Copy link
Author

@d-philpot, for awareness this is a PR to merge your gx51x pinctrl dts changes.

@lsd-he360 lsd-he360 marked this pull request as draft November 5, 2025 22:17
@lsd-he360 lsd-he360 marked this pull request as ready for review November 6, 2025 20:50
@lsd-he360
Copy link
Author

The lp_mspm0g3519 board dts file was updated to include the mspm0gx51x-pinctrl.dtsi:

zephyrproject-rtos/zephyr#98962

@lsd-he360
Copy link
Author

@ssekar15 @vaishnavachath

@ssekar15 ssekar15 self-assigned this Nov 11, 2025
@ssekar15 ssekar15 self-requested a review November 11, 2025 03:21
@d-philpot
Copy link
Collaborator

d-philpot commented Nov 14, 2025

Looks good to me, @ssekar15 can you review?

Copy link
Collaborator

@ssekar15 ssekar15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lsd-he360 I had a look into the pin configuration for g series, as far I checked most of them share the common base reference and difference is in additional pin on higher variant. I would suggest to cleanup with base common pinctl file which is included to add on for high variants with delta.

I could prepare a draft if needed

@d-philpot
Copy link
Collaborator

d-philpot commented Nov 16, 2025

@ssekar15 I think maintaining a common pinctrl file might be added overhead and prone to mistakes. I generated this file with a script

@ssekar15
Copy link
Collaborator

@ssekar15 I think maintaining a common pinctrl file might be added overhead and prone to mistakes. I generated this file with a script

Common pinctrl is to avoid mistakes with multiple effort, streamline only difference for better understanding. Most of G-series SoC shares the same baseline, we could improve the script. Please attach the script and update the README.

@ssekar15
Copy link
Collaborator

@ssekar15 I think maintaining a common pinctrl file might be added overhead and prone to mistakes. I generated this file with a script

Common pinctrl is to avoid mistakes with multiple effort, streamline only difference for better understanding. Most of G-series SoC shares the same baseline, we could improve the script. Please attach the script and update the README.

@d-philpot please confirm that I can start work on refactor to avoid double effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants