-
Notifications
You must be signed in to change notification settings - Fork 54
dts: add gx51x pinctrl file #76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Adds a seperate pinctrl file for gx51x family. This file shares many configurations with the g1x0x/g3x0x but supports additonal pins and peripherals. Signed-off-by: Dylan Philpot <[email protected]>
|
@d-philpot, for awareness this is a PR to merge your gx51x pinctrl dts changes. |
|
The lp_mspm0g3519 board dts file was updated to include the |
|
Looks good to me, @ssekar15 can you review? |
ssekar15
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lsd-he360 I had a look into the pin configuration for g series, as far I checked most of them share the common base reference and difference is in additional pin on higher variant. I would suggest to cleanup with base common pinctl file which is included to add on for high variants with delta.
I could prepare a draft if needed
|
@ssekar15 I think maintaining a common pinctrl file might be added overhead and prone to mistakes. I generated this file with a script |
Common pinctrl is to avoid mistakes with multiple effort, streamline only difference for better understanding. Most of G-series SoC shares the same baseline, we could improve the script. Please attach the script and update the README. |
@d-philpot please confirm that I can start work on refactor to avoid double effort. |
Adds a seperate pinctrl file for gx51x family. This file shares many configurations with the g1x0x/g3x0x but supports additonal pins and peripherals.
The commit in this PR is cherry picked from TexasInstruments/msp-hal_ti@e3968fe