tests: config: Split the skip cases #891
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdgendt
force-pushed
the
test-config-split-skipif
branch
from
d279da0 to
affeb83
Compare
thorsten-klein
approved these changes
Dec 1, 2025
pdgendt
force-pushed
the
test-config-split-skipif
branch
from
affeb83 to
71d19fa
Compare
Have the actual reason for skipping the test in the output. Signed-off-by: Pieter De Gendt <[email protected]>
pdgendt
force-pushed
the
test-config-split-skipif
branch
from
71d19fa to
ce53f0d
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #891 +/- ##
=======================================
Coverage 84.93% 84.93%
=======================================
Files 11 11
Lines 3444 3444
=======================================
Hits 2925 2925
Misses 519 519 |
marc-hb
reviewed
Dec 1, 2025
| assert cfg(f=LOCAL)['pytest']['precedence'] == 'local' | ||
|
|
||
|
|
||
| @pytest.mark.skipif(WINDOWS, reason="Non-readable files do not exist on Windows") |
Collaborator
There was a problem hiding this comment.
Suggested change
| @pytest.mark.skipif(WINDOWS, reason="Non-readable files do not exist on Windows") | |
| @pytest.mark.skipif(WINDOWS, reason="chmod is not available on Windows") |
Pretty sure NTFS can stop some users from reading some files!
Collaborator
Author
There was a problem hiding this comment.
It is available, but you can only make files read-only.
Collaborator
Author
There was a problem hiding this comment.
@marc-hb do you still prefer that I change to your suggestion? I'm fine either way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have the actual reason for skipping the test in the output.