Skip to content

tests: config: Split the skip cases #891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

tests: config: Split the skip cases #891

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions tests/test_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -703,9 +703,10 @@ def test_config_precedence():
assert cfg(f=LOCAL)['pytest']['precedence'] == 'local'


@pytest.mark.skipif(WINDOWS, reason="Non-readable files do not exist on Windows")
Copy link
Collaborator

@marc-hb marc-hb Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
@pytest.mark.skipif(WINDOWS, reason="Non-readable files do not exist on Windows")
@pytest.mark.skipif(WINDOWS, reason="chmod is not available on Windows")

Pretty sure NTFS can stop some users from reading some files!

Copy link
Collaborator Author

@pdgendt pdgendt Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is available, but you can only make files read-only.

Copy link
Collaborator Author

@pdgendt pdgendt Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marc-hb do you still prefer that I change to your suggestion? I'm fine either way.

@pytest.mark.skipif(
WINDOWS or (os.geteuid() == 0),
reason="Non-readable files do not exist on Windows, and root user can always read files",
hasattr(os, "geteuid") and os.geteuid() == 0,
reason="root user can always read files",
)
def test_config_non_readable_file(config_tmpdir):
# test to read a config file without read permission
Expand Down