STM32MP1 Series support #13794
Merged
STM32MP1 Series support #13794
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnopo
requested review from
MaureenHelm,
andrewboie,
dbkinder,
erwango and
galak
as code owners
|
Found the following issues, please fix and resubmit: License issuesIn most cases you do not need to do anything here, especially if the files
|
Codecov Report
@@ Coverage Diff @@
## master #13794 +/- ##
==========================================
+ Coverage 52.51% 52.68% +0.16%
==========================================
Files 309 307 -2
Lines 45048 45473 +425
Branches 10419 10530 +111
==========================================
+ Hits 23656 23956 +300
- Misses 16584 16640 +56
- Partials 4808 4877 +69
Continue to review full report at Codecov.
|
dbkinder
suggested changes
Feb 26, 2019
There was a problem hiding this comment.
add a blank line before the first entry of a (sub)list.
There was a problem hiding this comment.
add a blank line before this first list item (sublist)
There was a problem hiding this comment.
add a blank line (more instances of this problem below)
There was a problem hiding this comment.
Lots of formatting issues. Here's a recommended rewrite:
1) start OpenOCD in a dedicated terminal
- Start up the sdk environment::
source <SDK installation directory>/environment-setup-cortexa7hf-neon-vfpv4-openstlinux_weston-linux-gnueabi
- Start OpenOCD::
${OECORE_NATIVE_SYSROOT}/usr/bin/openocd -s ${OECORE_NATIVE_SYSROOT}/usr/share/openocd/scripts -f board/stm32mp15x_dk2.cfg
2) run gdb in Zephyr environment
.. code-block:: console
# On Linux
cd $ZEPHYR_BASE/samples/hello_world
mkdir -p build && cd build
# Use cmake to configure a Ninja-based build system:
cmake -GNinja -DBOARD=stm32mp157_dk2 ..
# Now run ninja on the generated build system:
ninja debug
|
recheck |
galak
previously requested changes
Feb 27, 2019
erwango
requested changes
Feb 28, 2019
soc/arm/st_stm32/stm32mp1/soc.h
Outdated
There was a problem hiding this comment.
Keep this for exti support commit
dts/arm/st/mp1/stm32mp157.dtsi
Outdated
dts/arm/st/mp1/stm32mp157.dtsi
Outdated
There was a problem hiding this comment.
Fyi, we use DT_SIZE_K macro to ease reading
ext/hal/st/stm32cube/stm32mp1xx/drivers/include/stm32mp1xx_ll_exti.h
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
We have sanitycheck script that look for non existing Kconfig symbols and we clean them up.
Remove CONFIG_SOC_SERIES_STM32{F7X MP1x}
erwango
requested changes
Mar 8, 2019
There was a problem hiding this comment.
Is that board specific?
Can't it be set in /soc ?
There was a problem hiding this comment.
should depend neither on board or soc but CONFIG:
- CONFIG_RAM_CONSOLE
- CONFIG_OPENAMP
I will try to change it in a more graceful way
dts/arm/st/mp1/stm32mp157.dtsi
Outdated
dbkinder
approved these changes
Mar 9, 2019
erwango
requested changes
Mar 11, 2019
erwango
requested changes
Mar 11, 2019
ext/hal/st/stm32cube/stm32mp1xx/drivers/src/stm32mp1xx_ll_exti.c
Outdated
Show resolved
Hide resolved
erwango
approved these changes
Mar 11, 2019
|
Looks good to me, one minor comment is the commit order in the PR seems odd. The board commit should be the last one. |
galak
approved these changes
Mar 20, 2019
I have changed the commit order and re-push commits. |
|
Update done to fix rebase issue on master (compilation failed due to 4da0f8b). |
|
Don't take into account false Kconfig fail: |
Add the initial SoC support for the STM32MP1 family. The code was tested on STM32MP157c, but should work on any STM32MP1XX currently available. Signed-off-by: Arnaud Pouliquen <[email protected]>
Provide required changes to stm32cube HAL and LL for the STM32MP1X series MCU. Origin: ST Microelectronics License: BSD-3-Clause URL: https://github.com/STMicroelectronics/STM32CubeMP1 Commit: 1.1.0 Purpose: HAL layer for STM32MP1 Maintained-by: External Signed-off-by: Arnaud Pouliquen <[email protected]>
The stm32mp1 exti ll driver is mandatory for compilation. add it on top of stm32cubeMP1 version 1.0.0. Signed-off-by: Arnaud Pouliquen <[email protected]>
Add the declaration of the ST Microlectronics stm32mp157 soc. Signed-off-by: Arnaud Pouliquen <[email protected]>
Add support of the stm32mp1 gpio exti. Signed-off-by: Arnaud Pouliquen <[email protected]>
Add configuration, pinmux, dts and documentation for the STM32MP157 Discovery board based on the STM32MP157 SoC. Signed-off-by: Arnaud Pouliquen <[email protected]>
The CONFIG_ prefix is reserved in Zephyr, rename CONFIG_SHIFT and associated constants by adding a RCC_ prefix Signed-off-by: Arnaud Pouliquen <[email protected]>
|
Hello Kumar,
Thank for the merge!
Arnaud
From: Kumar Gala <[email protected]>
Sent: vendredi 19 avril 2019 19:06
To: zephyrproject-rtos/zephyr <[email protected]>
Cc: Arnaud POULIQUEN <[email protected]>; Author <[email protected]>
Subject: Re: [zephyrproject-rtos/zephyr] STM32MP1 Series support (#13794)
Merged #13794<#13794> into master.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#13794 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AGCNTA2XHTSIMCANYRNBZPDPRH3WTANCNFSM4G2J5BXQ>.
|
ulfalizer
pushed a commit
to ulfalizer/zephyr
that referenced
this pull request
May 13, 2019
Referenced in PR zephyrproject-rtos#13794. Signed-off-by: Kumar Gala <[email protected]>
ulfalizer
pushed a commit
to ulfalizer/zephyr
that referenced
this pull request
Oct 23, 2019
Referenced in PR zephyrproject-rtos#13794. Signed-off-by: Kumar Gala <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add basic support of the Cortex-M4 core for the STM32MP1 processor.
Provide support for the stm32mp1 DK2 discovery board.
This first step allows to run and debug the Hello_world sample.