kernel: Add typedef forward declaration check for portability. #20605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'k_thread_stack_t' and 'k_thread_entry_t' typedefs are forward-declared in sys/arch_interface.h and, because this header is included by arch/cpu.h, which is, in turn, included by kernel_includes.h, the typedefs effectively get re-declared in kernel.h. While this does not cause a compilation error when compiling with GCC 4.6 and above, GCC 4.5 and below strictly enforce the C99 standard and do not allow redeclaration of the same typedef in the same scope. This commit adds sys/arch_interface.h header inclusion checks in kernel.h to skip declaration of the forward-declared typedefs. Signed-off-by: Stephanos Ioannidis <[email protected]>
stephanosio
added
the
area: Portability
Member
Author
|
Sample compilation error in GCC 4.5.1 due to redeclaration of the same typedefs: |
Member
Author
|
Closing this PR as #21018 removed the duplicate definitions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'k_thread_stack_t' and 'k_thread_entry_t' typedefs are forward-declared
in sys/arch_interface.h and, because this header is included by
arch/cpu.h, which is, in turn, included by kernel_includes.h, the
typedefs effectively get re-declared in kernel.h.
While this does not cause a compilation error when compiling with GCC
4.6 and above, GCC 4.5 and below strictly enforce the C99 standard and
do not allow redeclaration of the same typedef in the same scope.
This commit adds sys/arch_interface.h header inclusion checks in
kernel.h to skip declaration of the forward-declared typedefs.
Signed-off-by: Stephanos Ioannidis [email protected]