drivers: st7789: fix offset usage #20691
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Take offset form dt instead of hard code Signed-off-by: Pavlo Hamov <[email protected]>
vanwinkeljan
approved these changes
Nov 14, 2019
jfischer-no
requested changes
Nov 14, 2019
| * display is 320x170, and so the effective LCD is offset | ||
| * by 35 "rows". | ||
| */ | ||
| st7789v_set_lcd_margins(p_st7789v, 0, 35); |
Contributor
There was a problem hiding this comment.
It does not make sense, this file is for TL019FQV01 display, everything here is hardcoded, it is not generic. Working on support for Waveshare display, I will remove it and replace with byte arrays in DT.
Contributor
Author
There was a problem hiding this comment.
Agree that it's corner implementation. Are you willing to remove whole file (display_st7789v_tl019fqv01.c)?
Contributor
There was a problem hiding this comment.
It will be moved to display_st7789v.c and should obtain the values from DT. I think we should not have a display_st7789v_xVARIANTx.c per display.
Contributor
Author
There was a problem hiding this comment.
Great. Sincerely, i do not like these display_name_variant.c implementations. Thank you for taking care of this. Closing PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take offset form dt instead of hard code
Signed-off-by: Pavlo Hamov [email protected]