bluetooth: controller: radio: Use HAL API in radio_nrf5_ppi #30732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auroraslb
requested review from
carlescufi,
cvinayak,
kruithofa and
thoh-ot
as code owners
Hi, I've created a separate PR for the TX power changes (#30880). |
|
@auroraslb FYI, I have cherry-picked your changes with some changes here #30950, do review and take the changes as necessary/appropriate into this PR. |
auroraslb
force-pushed
the
use_hal_in_radio
branch
from
31bac2d to
9dafb78
Compare
|
@auroraslb will you follow-up on this PR? |
cvinayak
requested changes
Feb 25, 2021
subsys/bluetooth/controller/ll_sw/nordic/hal/nrf5/radio/radio_nrf5.h
Outdated
Show resolved
Hide resolved
rugeGerritsen
force-pushed
the
use_hal_in_radio
branch
from
9dafb78 to
2037919
Compare
Rewrite to use subscribe and publish functions for the different peripherals. This will make it possible to test the controller in a simulator. Signed-off-by: Aurora Sletnes Bjørlo <[email protected]>
Splits the file into radio_nrf5_ppi.h and radio_nrf5_dppi.h and moves the nRF53 DPPI to radio_nrf5_dppi.h. Signed-off-by: Aurora Sletnes Bjørlo <[email protected]>
rugeGerritsen
force-pushed
the
use_hal_in_radio
branch
from
2037919 to
1b8253a
Compare
cvinayak
requested changes
Feb 25, 2021
subsys/bluetooth/controller/ll_sw/nordic/hal/nrf5/radio/radio_nrf5.h
Outdated
Show resolved
Hide resolved
The hal requires one of these to be present. Signed-off-by: Rubin Gerritsen <[email protected]>
rugeGerritsen
force-pushed
the
use_hal_in_radio
branch
from
1b8253a to
fffc261
Compare
cvinayak
approved these changes
Feb 25, 2021
|
@rugeGerritsen any progress here? This is blocking #31336 and #30708 |
|
@cvinayak , all work in this PR is done. I see you have approved it. It is ready to be merged. |
carlescufi
approved these changes
Mar 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite some functions in radio_nrf5_ppi to use available HAL APIs for subscribe and publish. This will make it possible to test the controller in a simulator. Also add guards on TXPOWER to ensure positive values only are used if they are defined.