drivers: flash: update nrf_qspi_nor with JESD216 support #31045
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: Boards
area: Devicetree
area: Devicetree Binding
pabigot
force-pushed
the
nordic/20201229b
branch
from
1b4a8f2 to
ba178a2
Compare
pabigot
requested review from
MaureenHelm,
anangl,
galak,
nashif and
nvlsianpu
as code owners
pabigot
force-pushed
the
nordic/20201229b
branch
from
ba178a2 to
3eec958
Compare
nvlsianpu
reviewed
Jan 5, 2021
nvlsianpu
approved these changes
Jan 5, 2021
zephyrbot
added
area: RISCV
zephyrbot
requested review from
katsuster,
mbolivar-nordic,
mgielda and
nategraff-sifive
pabigot
force-pushed
the
nordic/20201229b
branch
from
3eec958 to
9649428
Compare
|
Rebased on merged #31042. |
de-nordic
reviewed
Jan 18, 2021
drivers/flash/jesd216.c
Outdated
There was a problem hiding this comment.
The filed is 5 bit long, shouldn't the mask be 0x1F?
There was a problem hiding this comment.
Quite right; fixed; thanks.
pabigot
force-pushed
the
nordic/20201229b
branch
from
9649428 to
f492964
Compare
de-nordic
reviewed
Jan 18, 2021
drivers/flash/jesd216.h
Outdated
de-nordic
reviewed
Jan 18, 2021
pabigot
force-pushed
the
nordic/20201229b
branch
from
f492964 to
61fddbc
Compare
DW indexes start from 1, so the proper upper bound includes the value of len_dw. Signed-off-by: Peter Bigot <[email protected]>
DW15 provides information on entry and exit from QSPI modes. In particular, it specifies whether and how the status register must be updated for this feature. Add a JESD216 devicetree property for the Quad Enable Requirements value. Signed-off-by: Peter Bigot <[email protected]>
DW16 provides information on mechanisms to enter and exit 4-Byte address modes, returning the device to reset state, and how to manipulate the values in the first status register. Signed-off-by: Peter Bigot <[email protected]>
Not all special commands require that a write-enable be issued first. Allow the caller to decide. Signed-off-by: Peter Bigot <[email protected]>
|
Rebase in attempt to fix bogus compliance failure https://github.com/zephyrproject-rtos/zephyr/pull/31045/checks?check_run_id=1722975715 |
pabigot
force-pushed
the
nordic/20201229b
branch
from
61fddbc to
29c3129
Compare
de-nordic
reviewed
Jan 18, 2021
de-nordic
approved these changes
Jan 18, 2021
The interface used to send commands supports only a command followed by 8 bytes of data transfer. Reject attempts to do more, as the result will be a successful transfer of only the first 8 bytes. Signed-off-by: Peter Bigot <[email protected]>
These are so long they can mandate line length mitigation. Avoid that. Signed-off-by: Peter Bigot <[email protected]>
Kconfig allowed selecting any bit in the status register as the QE bit, and defaulted it to 6. Devices need not require a QE bit at all, and where JESD216 defines QE bit location the only place in first SR byte that it can be is bit 6. Further, the code unconditionally wrote the value 0x40 without respecting configuration of other bits. Some of those bits control write protection of block-protected areas and should not be changed. Remove the Kconfig, instead using the jedec,jesd216-controlled devicetree property. Allow the driver to recognize whether or not setting the bit is required, and when it is only use bit 6. Only update if the setting does not match the configuration. Signed-off-by: Peter Bigot <[email protected]>
QSPI doesn't have a different length expectation than normal SPI, so introducing a new name for an existing name is unnecessary. Also replace the constant with the actual buffer size where appropriate, in somebody changes the the buffer definition. Signed-off-by: Peter Bigot <[email protected]>
Refactor slightly so we can read SFDP tables with this driver. Note that the SFDP read command requires long frame mode transfers as data exceeds 8 bytes. Signed-off-by: Peter Bigot <[email protected]>
Remove the overlay and set up to enable the QSPI variant. Signed-off-by: Peter Bigot <[email protected]>
pabigot
force-pushed
the
nordic/20201229b
branch
from
29c3129 to
91687c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #31042. The first several commits of this add DW15 and DW16 support, which could move to a separate PR as it's JESD216-specific, not Nordic-specific.
The rest updates the Nordic QSPI driver to be able to fetch SFDP data. This can be used to update several things, including but not limited to:
Those enhancements are not in the scope of this PR.