x86: add kconfigs and compiler flags for MMX and SSE* #31198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcpleung
requested review from
aasthagr,
andrewboie,
andyross,
jenmwms,
jhedberg,
nashif and
wentongwu
as code owners
github-actions
bot
added
area: API
andrewboie
reviewed
Jan 8, 2021
arch/x86/core/ia32/crt0.S
Outdated
There was a problem hiding this comment.
Is CONFIG_X86_SSE supposed to be a superset of all the configs like CONFIG_X86_SSE4A, for example?
Most of the asm code related to SSE applies to all SSE variants and also MMX since they are all using the same set of XMM registers
I don't think this will work if someone just selects CONFIG_X86_SSE4 for example
There was a problem hiding this comment.
Fixed to do select X86_SSE so CONFIG_X86_SSE is enabled when any SSE kconfig is enabled.
MMX registers overlay with FPU registers so only needs CONFIG_FPU.
dcpleung
force-pushed
the
x86_sse_kconfigs
branch
3 times, most recently
from
95d70b0 to
5157746
Compare
ceolin
reviewed
Jan 21, 2021
ceolin
reviewed
Jan 21, 2021
dcpleung
force-pushed
the
x86_sse_kconfigs
branch
from
5157746 to
222722f
Compare
It is possible to enable SSE without using SSE for floating point, so fix the compiler flags. Signed-off-by: Daniel Leung <[email protected]>
On x86, it is possible to use FPU (387) and SSE for floating point operations. So test both. Signed-off-by: Daniel Leung <[email protected]>
The app_kernel benchmarking app has the config file for benchmarking with floating point enabled, but it was never used. So add it to the testcase.yaml. Note that this also limits to run on one CPU on a SMP system as the resulting numbers would be more consistent among runs. Signed-off-by: Daniel Leung <[email protected]>
This adds X86 keyword to the kconfigs to indicate these are for x86. The old options are still there marked as deprecated. Signed-off-by: Daniel Leung <[email protected]>
This adds kconfigs and compiler flags to support MMX and SSE* instructions. Signed-off-by: Daniel Leung <[email protected]>
dcpleung
force-pushed
the
x86_sse_kconfigs
branch
from
222722f to
d6faf57
Compare
nashif
approved these changes
Jan 28, 2021
ceolin
approved these changes
Jan 28, 2021
jenmwms
approved these changes
Feb 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds kconfigs and compiler flags to support MMX and SSE* instructions.