Skip to content

Bluetooth: Mesh: Split Proxy services #36871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Sep 28, 2021
Merged

Bluetooth: Mesh: Split Proxy services #36871

merged 11 commits into from
Sep 28, 2021

Conversation

@LingaoM
Copy link
Contributor

@LingaoM LingaoM commented Jul 12, 2021 •
edited
Loading

we will no longer need the additional disconnect parameter,
such as we only process gatt database from disconnect handler.

Signed-off-by: Lingao Meng [email protected]

@LingaoM LingaoM added area: Bluetooth DNM This PR should not be merged (Do Not Merge) area: Bluetooth Mesh labels Jul 12, 2021
@trond-snekvik
Copy link
Contributor

trond-snekvik commented Jul 15, 2021

This PR contains multiple commits, which will be used to split the proxy services

@LingaoM this this end up changing, or is this still a work in progress? Is it ready for review?

@LingaoM
Copy link
Contributor Author

LingaoM commented Jul 15, 2021

I'm not ready. I'll deal with #36721 (comment) first, and then split the proxy. Maybe the following can be put in this pr.

@LingaoM LingaoM force-pushed the split_gatt_services branch from d43147c to eb3c4ea Compare August 3, 2021 11:49
@LingaoM LingaoM added the RFC Request For Comments: want input from the community label Aug 3, 2021
@LingaoM
Copy link
Contributor Author

LingaoM commented Aug 3, 2021

gatt_svc and filter_type will be processed in subsequent commits. The final is a complete split.

@LingaoM LingaoM force-pushed the split_gatt_services branch 3 times, most recently from 40bd976 to 7cd35a0 Compare August 3, 2021 12:58
trond-snekvik
trond-snekvik reviewed Aug 9, 2021
View reviewed changes
@LingaoM LingaoM force-pushed the split_gatt_services branch 3 times, most recently from fef4418 to fa9b5d4 Compare August 18, 2021 09:12
@LingaoM LingaoM removed the DNM This PR should not be merged (Do Not Merge) label Aug 18, 2021
@LingaoM LingaoM requested a review from trond-snekvik August 18, 2021 09:30
@LingaoM LingaoM force-pushed the split_gatt_services branch 3 times, most recently from b3f978f to 5f25822 Compare August 18, 2021 10:04
@LingaoM LingaoM removed the RFC Request For Comments: want input from the community label Aug 18, 2021
@LingaoM LingaoM force-pushed the split_gatt_services branch 2 times, most recently from ba86f69 to 9bb3e97 Compare August 18, 2021 10:23
LingaoM
LingaoM commented Aug 18, 2021
View reviewed changes
@LingaoM LingaoM force-pushed the split_gatt_services branch from 9bb3e97 to d5f4fab Compare August 19, 2021 01:11
PavelVPV
PavelVPV reviewed Sep 6, 2021
View reviewed changes
@LingaoM LingaoM force-pushed the split_gatt_services branch from f399f96 to 7d202dc Compare September 6, 2021 07:19
LingaoM
LingaoM commented Sep 7, 2021
View reviewed changes
PavelVPV
PavelVPV reviewed Sep 9, 2021
View reviewed changes
@LingaoM LingaoM force-pushed the split_gatt_services branch from 2ffd6c2 to dba8fef Compare September 9, 2021 09:05
@LingaoM LingaoM requested a review from PavelVPV September 9, 2021 09:06
@LingaoM LingaoM force-pushed the split_gatt_services branch from dba8fef to 411434d Compare September 9, 2021 09:15
@LingaoM LingaoM force-pushed the split_gatt_services branch 2 times, most recently from 2777e32 to d0c8cdc Compare September 15, 2021 01:18
@LingaoM
Bluetooth: Mesh: Delete bt_mesh_proxy_prov_disable parameter.
457fd3e 
we will no longer need the additional `disconnect` parameter,
such as we only process gatt database from disconnect handler.

Signed-off-by: Lingao Meng <[email protected]>
@LingaoM
Bluetooth: Mesh: Split gatt services to pb-gatt and proxy
c61b2fb 
Split gatt services to pb-gatt-srv and proxy-srv.

Signed-off-by: Lingao Meng <[email protected]>
@LingaoM
Bluetooth: Mesh: Rename bt_mesh_pb_gatt<*> function
17fa4d0 
Rename bt_mesh_pb_gatt_<*> function, and split from proxy.h

Signed-off-by: Lingao Meng <[email protected]>
@LingaoM
Bluetooth: Mesh: Remove unnecessary prov buf get function
6aba8bd 
Remove `bt_mesh_pb_gatt_get_buf`.

Signed-off-by: Lingao Meng <[email protected]>
@LingaoM
Bluetooth: Mesh: Move command buffer to proxy_msg.c
198c6c7 
Move command buffer alloc to proxy_msg.c.

Signed-off-by: Lingao Meng <[email protected]>
@LingaoM
Bluetooth: Mesh: Move proxy complete message to seperate role
6f4b18b 
Move proxy complete message to seperate role.

Signed-off-by: Lingao Meng <[email protected]>
@LingaoM
Bluetooth: Mesh: Move bt_mesh_proxy_role to proxy_msg.c
62db91e 
Mesh bt_mesh_proxy_role structure to proxy_msg.c

Signed-off-by: Lingao Meng <[email protected]>
@LingaoM
Bluetooth: Mesh: Reflact disconnect logic to separate roles
49c0a19 
remove section ordering to use code more readable.

Signed-off-by: Lingao Meng <[email protected]>
@LingaoM
Bluetooth: Mesh: Add seperate config for pb-gatt dev name
28664d1 
Add seperate config to control whether device name include in
pb-gatt advertising scan response data.

Signed-off-by: Lingao Meng <[email protected]>
@LingaoM
Bluetooth: Mesh: Use common buf size for all conn
1a4b57e 
Use common buffer size for all bluetooth mesh connection.

Signed-off-by: Lingao Meng <[email protected]>
@LingaoM
Bluetooth: Mesh: Move proxy message size to kconfig
1999946 
Add `BT_MESH_PROXY_MSG_LEN` to config proxy message length

Signed-off-by: Lingao Meng <[email protected]>
@LingaoM LingaoM force-pushed the split_gatt_services branch from d0c8cdc to 1999946 Compare September 15, 2021 11:24
@LingaoM LingaoM requested a review from carlescufi September 16, 2021 07:05
@cfriedt
Copy link
Member

cfriedt commented Sep 28, 2021

@jhedberg - can you also ack?

@cfriedt cfriedt merged commit 5ddbdce into zephyrproject-rtos:main Sep 28, 2021
@sjanc sjanc mentioned this pull request Oct 4, 2021
Merged
@LingaoM LingaoM mentioned this pull request Nov 5, 2021
Merged
LingaoM
LingaoM commented Nov 9, 2021
View reviewed changes
subsys/bluetooth/mesh/proxy_srv.c
continue;
}

if (!client_filter_match(client, dst)) {
continue;
}

if (client->filter_type == PROV) {
Copy link
Contributor Author

@LingaoM LingaoM Nov 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#40158 (comment)

@jhedberg

@trond-snekvik trond-snekvik mentioned this pull request Nov 25, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PavelVPV PavelVPV PavelVPV approved these changes

@jhedberg jhedberg Awaiting requested review from jhedberg

@joerchan joerchan Awaiting requested review from joerchan

@Vudentz Vudentz Awaiting requested review from Vudentz

@carlescufi carlescufi Awaiting requested review from carlescufi

+1 more reviewer

@trond-snekvik trond-snekvik trond-snekvik approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@trond-snekvik trond-snekvik

Labels

area: Bluetooth Mesh area: Bluetooth

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@LingaoM @trond-snekvik @cfriedt @PavelVPV