Bluetooth: Mesh: Split Proxy services #36871
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LingaoM
added
area: Bluetooth
DNM
LingaoM
requested review from
Vudentz,
jhedberg,
joerchan and
trond-snekvik
as code owners
Contributor
@LingaoM this this end up changing, or is this still a work in progress? Is it ready for review? |
Contributor
Author
|
I'm not ready. I'll deal with #36721 (comment) first, and then split the proxy. Maybe the following can be put in this pr. |
LingaoM
force-pushed
the
split_gatt_services
branch
from
d43147c to
eb3c4ea
Compare
Contributor
Author
|
|
LingaoM
force-pushed
the
split_gatt_services
branch
3 times, most recently
from
40bd976 to
7cd35a0
Compare
LingaoM
force-pushed
the
split_gatt_services
branch
3 times, most recently
from
fef4418 to
fa9b5d4
Compare
LingaoM
force-pushed
the
split_gatt_services
branch
3 times, most recently
from
b3f978f to
5f25822
Compare
LingaoM
force-pushed
the
split_gatt_services
branch
2 times, most recently
from
ba86f69 to
9bb3e97
Compare
LingaoM
commented
Aug 18, 2021
LingaoM
force-pushed
the
split_gatt_services
branch
from
9bb3e97 to
d5f4fab
Compare
PavelVPV
reviewed
Sep 6, 2021
LingaoM
force-pushed
the
split_gatt_services
branch
from
f399f96 to
7d202dc
Compare
LingaoM
commented
Sep 7, 2021
PavelVPV
reviewed
Sep 9, 2021
LingaoM
force-pushed
the
split_gatt_services
branch
from
2ffd6c2 to
dba8fef
Compare
LingaoM
force-pushed
the
split_gatt_services
branch
from
dba8fef to
411434d
Compare
trond-snekvik
approved these changes
Sep 9, 2021
PavelVPV
approved these changes
Sep 9, 2021
LingaoM
force-pushed
the
split_gatt_services
branch
2 times, most recently
from
2777e32 to
d0c8cdc
Compare
we will no longer need the additional `disconnect` parameter, such as we only process gatt database from disconnect handler. Signed-off-by: Lingao Meng <[email protected]>
Split gatt services to pb-gatt-srv and proxy-srv. Signed-off-by: Lingao Meng <[email protected]>
Rename bt_mesh_pb_gatt_<*> function, and split from proxy.h Signed-off-by: Lingao Meng <[email protected]>
Remove `bt_mesh_pb_gatt_get_buf`. Signed-off-by: Lingao Meng <[email protected]>
Move command buffer alloc to proxy_msg.c. Signed-off-by: Lingao Meng <[email protected]>
Move proxy complete message to seperate role. Signed-off-by: Lingao Meng <[email protected]>
Mesh bt_mesh_proxy_role structure to proxy_msg.c Signed-off-by: Lingao Meng <[email protected]>
remove section ordering to use code more readable. Signed-off-by: Lingao Meng <[email protected]>
Add seperate config to control whether device name include in pb-gatt advertising scan response data. Signed-off-by: Lingao Meng <[email protected]>
Use common buffer size for all bluetooth mesh connection. Signed-off-by: Lingao Meng <[email protected]>
Add `BT_MESH_PROXY_MSG_LEN` to config proxy message length Signed-off-by: Lingao Meng <[email protected]>
LingaoM
force-pushed
the
split_gatt_services
branch
from
d0c8cdc to
1999946
Compare
Member
|
@jhedberg - can you also ack? |
LingaoM
commented
Nov 9, 2021
| continue; | ||
| } | ||
|
|
||
| if (!client_filter_match(client, dst)) { | ||
| continue; | ||
| } | ||
|
|
||
| if (client->filter_type == PROV) { |
Contributor
Author
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we will no longer need the additional
disconnectparameter,such as we only process gatt database from disconnect handler.
Signed-off-by: Lingao Meng [email protected]