drivers: sensor: Add support for BH1750 ambient light sensor #43086
Conversation
github-actions
bot
added
area: Devicetree
area: Devicetree Binding
zephyrbot
requested review from
avisconti,
gmarull,
mbolivar-nordic and
teburd
gmarull
left a comment
gmarull
left a comment
There was a problem hiding this comment.
Seems like some files have formatting issues (missing EOF blank line)
|
We might want to combine efforts between the downstream NCS version of the BH1749 (nrfconnect/sdk-nrf#6799) and this if they are similar enough. |
|
mbolivar-nordic From what I see BH1749 is far more sophisticated (allows to grab individual RGB and IR values, dedicated hardware INT), not sure if the sensors are similar enough to merge those drivers into one |
morsisko
force-pushed
the
bh1750
branch
4 times, most recently
from
7a34137 to
b01b423
Compare
mbolivar-nordic
left a comment
mbolivar-nordic
left a comment
There was a problem hiding this comment.
-1 on the binding's use of defaults. I didn't review the rest.
morsisko
force-pushed
the
bh1750
branch
2 times, most recently
from
15f972c to
9932539
Compare
|
The justification is added, conflicts are resolved. |
mbolivar-nordic
left a comment
mbolivar-nordic
left a comment
There was a problem hiding this comment.
Looks reasonable, thanks
MaureenHelm
left a comment
MaureenHelm
left a comment
There was a problem hiding this comment.
Thanks for your contribution.
Please add this sensor to tests/drivers/build_all/sensor
morsisko
requested review from
gmarull
and removed request for
teburd and
yperess
|
Should I resolve the conflict or will it be resolved by the integrator? I think if I resolve it then another one will appear soon (as this is conflict in the test file) |
Yes, please rebase and resolve the conflict. |
This commit adds support for BH1750 ambient light sensor. The driver works using I2C peripheral in one-time mode. Signed-off-by: Michal morsisko <[email protected]>
|
@MaureenHelm ok, rebased |
morsisko
requested review from
MaureenHelm and
gmarull
and removed request for
avisconti,
galak,
gmarull,
teburd and
yperess
7 participants
This pull request adds support for BH1750 ambient light sensor along with sample application.
For now this driver features only one-time mode. If this version looks good for you, I can try to implement continuous mode in future pull request, although it will be tricky, because this sensor hasn't got physical GPIO INT, so the trigger would need to be "emulated" (I discussed it at Discord and it turns out that using delayed work could be a nice idea, but I don't think any other Zephyr sensor driver implements it)