soc: arm: atmel: implement SAM V70 support #46362

iperry · 2022-06-08T06:12:48Z

This patchset implements support for the Atmel SAM V70(b) series devices.

Just the basics, soc/ and DTS bindings.

Requires zephyrproject-rtos/hal_atmel#23

Signed-off-by: Perry Hung [email protected]

zephyrbot · 2022-06-08T06:13:54Z

The following west manifest projects have been modified in this Pull Request:

Name	Old Revision	New Revision	Diff
hal_atmel	zephyrproject-rtos/hal_atmel@`78c5567`	zephyrproject-rtos/hal_atmel#23	zephyrproject-rtos/hal_atmel#23/files

Note: This message is automatically posted and updated by the Manifest GitHub Action.

nandojve · 2022-06-08T10:54:40Z

Hi @iperry ,

To move with this we need a board to build at CI at least. As far I remember, there is no official board available from MCHP that uses SAMV70. Once SAMV70 it is a subset from SAMV71 (less Ethernet) I`ll suggest to add entries at boards/arm/sam_v71_xult for that purpose. In this case, there will be have 4 targets inside sam_v71_xult board directory.

iperry · 2022-06-08T18:32:39Z

Hi @iperry ,

To move with this we need a board to build at CI at least. As far I remember, there is no official board available from MCHP that uses SAMV70. Once SAMV70 it is a subset from SAMV71 (less Ethernet) I`ll suggest to add entries at boards/arm/sam_v71_xult for that purpose. In this case, there will be have 4 targets inside sam_v71_xult board directory.

Hello @nandojve , thank you for the review. I don't fully understand what you would like me to do. Can you clarify what you mean?

Should I copy the board overlay for the sam_v71_xult and make a new, fake one for an imaginary board? In particular, I am not sure about:

What to name it
Where to put the Kconfig options
Do I make a new board name, defconfig, dts, pin-ctrl, and yaml file for a imaginary board?

nandojve · 2022-06-09T06:21:03Z

Hi @iperry ,

Should I copy the board overlay for the sam_v71_xult and make a new, fake one for an imaginary board? In particular, I am not sure about:

What to name it

Where to put the Kconfig options

Do I make a new board name, defconfig, dts, pin-ctrl, and yaml file for a imaginary board?

Zephyr identify boards by content inside a board directory, not necessarily the directory name itself. When you run west boards you already see two boards for sam_v71_xult: sam_v71_xult and sam_v71b_xult. Now you need add two other boards: sam_v70_xult and sam_v70b_xult.

2-3. There is no necessity to create a new board directory. You need just create sam_v70[b]xult.dts, sam_v70[b]xult.yaml and sam_v7[b]xult_defconfig files to make a new board available to Zephyr. You need edit Kconfig.foo, openocd.cfg and index.rst files. In the case of documentation you should mention the support of SAMV70 and clarify that only network is not available in this specific Zephyr board. You should rename sam_v71_xult-pinctrl.dtsi as sam_v7x_xult-pinctrl-common.dtsi to be included by two new files sam_v71_xult-pinctrl.dtsi and sam_v70_xult-pinctrl.dtsi. We need to do this to make sure we are including correct dt-bindings pinctrl file. You should do a similar process with sam_v71_xult-common.dtsi and move gmac node to a new sam_v71_xult-common.dtsi file. I think it may not be necessary create a sam_v70_xult-common.dtsi file.

Note: It is possible to use Kconfig variables to instruct OpenOCD, see below as reference:

zephyr/boards/common/openocd.board.cmake

Lines 7 to 9 in d84989a

    
           if(CONFIG_X86 OR CONFIG_ARC) 
        
             set_ifndef(OPENOCD_USE_LOAD_IMAGE YES) 
        
           endif()

Import upstream ASF support pack for the SAM V70(b) series devices. Signed-off-by: Perry Hung <[email protected]>

Add DTS bindings for the SAM V70(b) device family. Signed-off-by: Perry Hung <[email protected]>

Implement soc files for the samv70(b) family devices. Signed-off-by: Perry Hung <[email protected]>

iperry · 2022-06-10T09:46:59Z

Hi @nandojve , thanks for the clarification.

I've prepared two test targets that I believe sort of implements what you are going for. I introduced two boards, ran twister tests, and fixed any Kconfig errors that I could find.

Introduce two new variations (sam_v70_xult and sam_v70b_xult) of the SAM V71 Xplained Ultra development board. While these are not actually manufactured variations, they exist to test the SAM V70 support. These boards are configured with an ATSAMV70Q20(b) processor and are functionally identical to the SAM V71 versions, minus Ethernet. Signed-off-by: Perry Hung <[email protected]>

nandojve

Hi @iperry,

Almost there. See my comments.

nandojve · 2022-06-11T12:18:49Z

drivers/can/Kconfig.sam

+
+if CAN_SAM
+
+config CAN_MAX_FILTER
+	int "Maximum number of concurrent active filters"
+	default 5
+	range 1 32
+	help
+	  Defines the array size of the callback/msgq pointers.
+	  Must be at least the size of concurrent reads.
+
+endif # CAN_SAM


This seems to be a separated commit or could even be on a different PR.
Could you clarify?

This Kconfig is not needed by the Bosch M_CAN driver backend. Please remove it.

nandojve · 2022-06-11T12:19:52Z

drivers/flash/Kconfig.sam

 	depends on SOC_SERIES_SAME70 || \
-		   SOC_SERIES_SAMV71
+		   SOC_SERIES_SAMV71 || SOC_SERIES_SAMV70


Keep pattern of one per line were V70 came before V71

nandojve · 2022-06-11T12:22:50Z

soc/arm/atmel_sam/samv70/Kconfig.defconfig.series

+# are used).
+#
+config NUM_IRQS
+	default 74 if SOC_ATMEL_SAMV70_REVB


71 instead 74, check typedef enum IRQn

nandojve · 2022-06-11T12:23:02Z

soc/arm/atmel_sam/samv70/Kconfig.defconfig.series

+#
+config NUM_IRQS
+	default 74 if SOC_ATMEL_SAMV70_REVB
+	default 71


69 instead 71, check typedef enum IRQn

nandojve · 2022-06-11T12:30:54Z

boards/arm/sam_v71_xult/Kconfig.defconfig

+
+if BOARD_SAM_V70_XULT
+
+config BOARD
+	default "sam_v70_xult"
+
+endif # BOARD_SAM_V70_XULT


Let's try keep less specialized always first.

nandojve · 2022-06-11T12:31:17Z

boards/arm/sam_v71_xult/Kconfig.board

+
+config BOARD_SAM_V70_XULT
+	bool "Atmel SMART SAM V70 Xplained Ultra Board"
+	depends on SOC_PART_NUMBER_SAMV70Q20 || SOC_PART_NUMBER_SAMV70Q20B


Let's try keep less specialized always first.

nandojve · 2022-06-11T12:31:53Z

boards/arm/sam_v71_xult/doc/index.rst

+SAM V70/V71 (B) Xplained Ultra
+##############################


nandojve · 2022-06-11T12:36:28Z

dts/arm/atmel/samv70.dtsi

+
+#include <atmel/same70.dtsi>
+
+#include "dma_atmel_samv71.h"


You should exclude gmac node here.

nandojve · 2022-06-11T12:36:35Z

dts/arm/atmel/samv70b.dtsi

+
+#include <atmel/same70b.dtsi>
+
+#include "dma_atmel_samv71.h"


You should exclude gmac node here.

henrikbrixandersen · 2022-06-14T12:08:05Z

drivers/can/Kconfig.sam

+
+if CAN_SAM
+
+config CAN_MAX_FILTER
+	int "Maximum number of concurrent active filters"
+	default 5
+	range 1 32
+	help
+	  Defines the array size of the callback/msgq pointers.
+	  Must be at least the size of concurrent reads.
+
+endif # CAN_SAM


This Kconfig is not needed by the Bosch M_CAN driver backend. Please remove it.

nandojve · 2022-08-01T10:31:45Z

Hi @iperry ,

I was wondering if you have time to address our concerns. It will be nice have it for 3.2

github-actions · 2022-10-28T00:36:11Z

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

iperry requested review from MaureenHelm, galak and ioannisg as code owners June 8, 2022 06:12

github-actions bot added area: Devicetree area: Modules labels Jun 8, 2022

zephyrbot added manifest west manifest-hal_atmel DNM This PR should not be merged (Do Not Merge) labels Jun 8, 2022

zephyrbot added the platform: Microchip SAM Microchip SAM Platform (formerly Atmel SAM) label Jun 8, 2022

zephyrbot requested review from mnkp, nandojve and stephanosio June 8, 2022 10:54

zephyrbot assigned nandojve Jun 8, 2022

iperry added 3 commits June 10, 2022 02:35

west.yml: hal_atmel: import ASF headers for SAMV70

a859fae

Import upstream ASF support pack for the SAM V70(b) series devices. Signed-off-by: Perry Hung <[email protected]>

dts: arm: atmel: add samv70 dts bindings

ca46598

Add DTS bindings for the SAM V70(b) device family. Signed-off-by: Perry Hung <[email protected]>

soc: samv70: add SAM V70 soc support

4c864d7

Implement soc files for the samv70(b) family devices. Signed-off-by: Perry Hung <[email protected]>

iperry force-pushed the samv70 branch from 13d1cf3 to 3e60660 Compare June 10, 2022 09:39

iperry requested review from alexanderwachter, henrikbrixandersen, nashif, nvlsianpu, pfalcon and tbursztyka as code owners June 10, 2022 09:39

zephyrbot added area: Flash area: Ethernet labels Jun 10, 2022

zephyrbot added the area: CAN label Jun 10, 2022

zephyrbot requested review from karstenkoenig and martinjaeger June 10, 2022 09:39

iperry force-pushed the samv70 branch from 3e60660 to dc091df Compare June 10, 2022 09:50

iperry mentioned this pull request Jun 10, 2022

ext: import ASF samv70(b) headers zephyrproject-rtos/hal_atmel#23

Closed

nandojve changed the title ~~soc: dts: implement SAM V70 support~~ soc: arm: atmel: implement SAM V70 support Jun 11, 2022

nandojve added this to the v3.2.0 milestone Jun 11, 2022

nandojve requested changes Jun 11, 2022

View reviewed changes

henrikbrixandersen requested changes Jun 14, 2022

View reviewed changes

nandojve modified the milestones: v3.2.0, future Aug 28, 2022

github-actions bot added the Stale label Oct 28, 2022

github-actions bot closed this Nov 12, 2022

		SAM V70/V71 (B) Xplained Ultra
		##############################


		#include <atmel/same70.dtsi>

		#include "dma_atmel_samv71.h"


		#include <atmel/same70b.dtsi>

		#include "dma_atmel_samv71.h"

soc: arm: atmel: implement SAM V70 support #46362

soc: arm: atmel: implement SAM V70 support #46362

Uh oh!

Conversation

iperry commented Jun 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zephyrbot commented Jun 8, 2022

Uh oh!

nandojve commented Jun 8, 2022

Uh oh!

iperry commented Jun 8, 2022

Uh oh!

nandojve commented Jun 9, 2022

Uh oh!

iperry commented Jun 10, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nandojve left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nandojve Jun 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nandojve Jun 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nandojve commented Aug 1, 2022

Uh oh!

github-actions bot commented Oct 28, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

iperry commented Jun 8, 2022 •

edited

Loading

iperry commented Jun 10, 2022 •

edited

Loading

nandojve Jun 11, 2022 •

edited

Loading

nandojve Jun 11, 2022 •

edited

Loading