-
Notifications
You must be signed in to change notification settings - Fork 8.2k
VL53L1X time-of-flight sensor. #53943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VL53L1X time-of-flight sensor. #53943
Conversation
4bdd1f2 to
ffbf1af
Compare
|
@MaureenHelm The compliance checks or failing rn due to typedefs. The STM library has some typedefs that I cannot remove. Some of the platform/HAL .h/.c files need to be adapted to work with zephyr. Therefore, some files from the library need to be included in the driver and certain definitions modifies to work in zephyr. The typedefs, for example, which are currently causing the compliance checks to fail, are types used throughout the library and cannot be changed. However, there is a similar driver for the (different) vl53l0x sensor that already lives in drivers/sensor in zephyr that uses a similar library by STM, and also has these typedefs, but doesn't appear to be an issue since it is in the main zephyr tree. |
321e3f7 to
9889362
Compare
38d2d75 to
fe7af75
Compare
|
@markCwatson - you will still need to rebase on main and resolve conflicts manually. I would be happy to re-approve after that. |
f596604 to
f0ece8e
Compare
|
Thanks a bunch @cfriedt. @MaureenHelm @erwango @avisconti @nashif @stephanosio, sorry to tag you all again, this branch had a conflict that needed to be resolved, so I had to address it. Would love to get this approved/merged so I don't have to keep doing this and bug everyone to give their approvals again LOL |
f0ece8e to
fac1df9
Compare
|
Arg....another merge conflict, so now this needs another rebase. :( @yperess this has been a recurring problem since you reworked |
The driver utilizes ST Microelectronics library (which exists in modules\hal\st\sensor\vl53l1x. Platform specific headers and source files used by the library are included and adapted for Zephyr. The driver can be configured in proj.conf to use a interrupt/polling methods and the use of the XSHUT pin on the VL53L1X. All uses were tested successfully. Signed-off-by: Mark Watson <[email protected]>
0010ff0
fac1df9 to
0010ff0
Compare
Thanks @MaureenHelm. I addressed the merge conflict. I appreciate everyone taking the time to come back again and again to give their approvals. I am going to tag everyone once again and kindly ask for their approvals so we can push this through before the next merge conflict arises: @cfriedt @erwango @teburd @avisconti @nashif @stephanosio |
I'll take a look and run some ideas by you. I'll make an issue for it so we can discuss options. |
The driver utilizes ST Microelectronics library (which exists in modules\hal\st\sensor\vl53l1x). Platform specific headers and source files used by the library are included and adapted for Zephyr.
The driver can be configured in proj.conf to use an interrupt/polling methods and use of the XSHUT pin on the VL53L1X. All uses were tested successfully.
A sample application was developed to test the driver. Due to Zephyr's desire to limit the number of sample applications for specific drivers, it was decided to not include the sample app in this PR. There is a similar app for another time-of-flight sensor (the VL53L0X). It was recommended to adapt this other sample app to be configurable to use either the VL53L0X or the VL53L1X.
Signed-off-by: Mark Watson [email protected]